Page MenuHomeFreeBSD
Differential D39888

pf :Reduce number of hashing operations when handling source nodes
ClosedPublic
Actions

Authored by vegeta_tuxpowered.net on Apr 30 2023, 7:40 PM.
Tags
None
Referenced Files
F168160657: D39888.id121276.diff
Wed, Aug 26, 4:02 PM
F168155241: D39888.id121275.diff
Wed, Aug 26, 3:26 PM
F168146634: D39888.id121289.diff
Wed, Aug 26, 2:29 PM
F168119941: D39888.id121291.diff
Wed, Aug 26, 11:39 AM
Unknown Object (File)
Tue, Aug 25, 10:44 AM
Unknown Object (File)
Tue, Aug 25, 9:10 AM
Unknown Object (File)
Mon, Aug 24, 2:40 PM
Unknown Object (File)
Mon, Aug 24, 1:04 PM
View All Files
Subscribers
ae
farrokhi
glebius
imp
melifaro

Details

Reviewers
kp
mjg
Commits
rGdb0a2bfd0c6d: pf: reduce number of hashing operations when handling source nodes
Summary

Reduce number of hashing operations when handling source nodes by always having a pointer to the hash row mutex in the source node. Provide macros for handling and asserting the mutex. Calculate the hash only once in pf_find_src_node() and then use this hash in subsequent operations.

Cherry-picked from development of D39880

Sponsored by: InnoGames GmbH

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

vegeta_tuxpowered.net created this revision.Apr 30 2023, 7:40 PM
Herald added subscribers: glebius, melifaro, farrokhi and 2 others. · View Herald TranscriptApr 30 2023, 7:40 PM
vegeta_tuxpowered.net requested review of this revision.Apr 30 2023, 7:40 PM
vegeta_tuxpowered.net updated this revision to Diff 121276.Apr 30 2023, 9:28 PM

Removed unnecessary state lock assertion.

kp added inline comments.May 1 2023, 8:42 AM
sys/net/pfvar.h
396

That may want to be mtx_lock((sn)->lock), just for safety.

2219

Should we take the opportunity to turn that int returnlocked into bool returnlocked?

kp added a reviewer: mjg.May 1 2023, 8:43 AM
vegeta_tuxpowered.net updated this revision to Diff 121289.May 1 2023, 1:31 PM

Updated pointer handing. Changed the flag to boolean.

kp accepted this revision.May 1 2023, 1:40 PM

I think this looks good, but I want to give Mateusz some time to take a look too.

This revision is now accepted and ready to land.May 1 2023, 1:40 PM
vegeta_tuxpowered.net updated this revision to Diff 121291.May 1 2023, 1:50 PM
vegeta_tuxpowered.net marked 2 inline comments as done.
This revision now requires review to proceed.May 1 2023, 1:50 PM
vegeta_tuxpowered.net updated this revision to Diff 121292.May 1 2023, 1:53 PM

The returnlocked flag is now a booelan.

mjg accepted this revision.May 1 2023, 1:58 PM
This revision is now accepted and ready to land.May 1 2023, 1:58 PM
Closed by commit rGdb0a2bfd0c6d: pf: reduce number of hashing operations when handling source nodes (authored by vegeta_tuxpowered.net, committed by kp). · Explain WhyMay 1 2023, 2:17 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rGdb0a2bfd0c6d: pf: reduce number of hashing operations when handling source nodes.

Revision Contents
Changeset List

PathSize
sys/
net/
39 lines
netpfil/
pf/
55 lines
3 lines

Diff 121291

View Options

sys/net/pfvar.h

Loading...
View Options

sys/netpfil/pf/pf.c

Loading...
View Options

sys/netpfil/pf/pf_lb.c

Loading...