Page MenuHomeFreeBSD
Differential D39888

pf :Reduce number of hashing operations when handling source nodes
ClosedPublic
Actions

Authored by vegeta_tuxpowered.net on Apr 30 2023, 7:40 PM.
Tags
None
Referenced Files
F93132166: D39888.id121275.diff
Sat, Sep 7, 12:44 PM
Unknown Object (File)
Thu, Aug 29, 10:33 PM
Unknown Object (File)
Sat, Aug 24, 10:42 PM
Unknown Object (File)
Mon, Aug 12, 3:22 AM
Unknown Object (File)
Jul 30 2024, 3:57 AM
Unknown Object (File)
Jul 23 2024, 12:34 PM
Unknown Object (File)
Jul 15 2024, 4:34 AM
Unknown Object (File)
Jul 15 2024, 2:03 AM
View All 51 Files
Subscribers
ae
farrokhi
glebius
imp
melifaro

Details

Reviewers
kp
mjg
Commits
rGdb0a2bfd0c6d: pf: reduce number of hashing operations when handling source nodes
Summary

Reduce number of hashing operations when handling source nodes by always having a pointer to the hash row mutex in the source node. Provide macros for handling and asserting the mutex. Calculate the hash only once in pf_find_src_node() and then use this hash in subsequent operations.

Cherry-picked from development of D39880

Sponsored by: InnoGames GmbH

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

vegeta_tuxpowered.net created this revision.Apr 30 2023, 7:40 PM
Herald added subscribers: glebius, melifaro, farrokhi and 2 others. · View Herald TranscriptApr 30 2023, 7:40 PM
vegeta_tuxpowered.net requested review of this revision.Apr 30 2023, 7:40 PM
vegeta_tuxpowered.net updated this revision to Diff 121276.Apr 30 2023, 9:28 PM

Removed unnecessary state lock assertion.

kp added inline comments.May 1 2023, 8:42 AM
sys/net/pfvar.h
396

That may want to be mtx_lock((sn)->lock), just for safety.

2219

Should we take the opportunity to turn that int returnlocked into bool returnlocked?

kp added a reviewer: mjg.May 1 2023, 8:43 AM
vegeta_tuxpowered.net updated this revision to Diff 121289.May 1 2023, 1:31 PM

Updated pointer handing. Changed the flag to boolean.

kp accepted this revision.May 1 2023, 1:40 PM

I think this looks good, but I want to give Mateusz some time to take a look too.

This revision is now accepted and ready to land.May 1 2023, 1:40 PM
vegeta_tuxpowered.net updated this revision to Diff 121291.May 1 2023, 1:50 PM
vegeta_tuxpowered.net marked 2 inline comments as done.
This revision now requires review to proceed.May 1 2023, 1:50 PM
vegeta_tuxpowered.net updated this revision to Diff 121292.May 1 2023, 1:53 PM

The returnlocked flag is now a booelan.

mjg accepted this revision.May 1 2023, 1:58 PM
This revision is now accepted and ready to land.May 1 2023, 1:58 PM
Closed by commit rGdb0a2bfd0c6d: pf: reduce number of hashing operations when handling source nodes (authored by vegeta_tuxpowered.net, committed by kp). · Explain WhyMay 1 2023, 2:17 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rGdb0a2bfd0c6d: pf: reduce number of hashing operations when handling source nodes.

Revision Contents
Changeset List

PathSize
sys/
net/
39 lines
netpfil/
pf/
53 lines
3 lines

Diff 121276

View Options

sys/net/pfvar.h

Loading...
View Options

sys/netpfil/pf/pf.c

Loading...
View Options

sys/netpfil/pf/pf_lb.c

Loading...