Page MenuHomeFreeBSD

pf :Reduce number of hashing operations when handling source nodes
ClosedPublic

Authored by vegeta_tuxpowered.net on Apr 30 2023, 7:40 PM.
Tags
None
Referenced Files
F93132166: D39888.id121275.diff
Sat, Sep 7, 12:44 PM
Unknown Object (File)
Thu, Aug 29, 10:33 PM
Unknown Object (File)
Sat, Aug 24, 10:42 PM
Unknown Object (File)
Mon, Aug 12, 3:22 AM
Unknown Object (File)
Jul 30 2024, 3:57 AM
Unknown Object (File)
Jul 23 2024, 12:34 PM
Unknown Object (File)
Jul 15 2024, 4:34 AM
Unknown Object (File)
Jul 15 2024, 2:03 AM

Details

Summary

Reduce number of hashing operations when handling source nodes by always having a pointer to the hash row mutex in the source node. Provide macros for handling and asserting the mutex. Calculate the hash only once in pf_find_src_node() and then use this hash in subsequent operations.

Cherry-picked from development of D39880

Sponsored by: InnoGames GmbH

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Removed unnecessary state lock assertion.

sys/net/pfvar.h
396

That may want to be mtx_lock((sn)->lock), just for safety.

2219

Should we take the opportunity to turn that int returnlocked into bool returnlocked?

Updated pointer handing. Changed the flag to boolean.

I think this looks good, but I want to give Mateusz some time to take a look too.

This revision is now accepted and ready to land.May 1 2023, 1:40 PM
This revision now requires review to proceed.May 1 2023, 1:50 PM

The returnlocked flag is now a booelan.

This revision is now accepted and ready to land.May 1 2023, 1:58 PM