Page MenuHomeFreeBSD
Differential D39665

ichiic: use bool for one-bit wide bit-fields
ClosedPublic
Actions

Authored by dim on Apr 18 2023, 6:09 PM.
Tags
None
Referenced Files
F163536685: D39665.diff
Fri, Jul 24, 6:14 AM
Unknown Object (File)
Tue, Jul 21, 4:27 AM
Unknown Object (File)
Jun 24 2026, 12:50 PM
Unknown Object (File)
Jun 24 2026, 8:31 AM
Unknown Object (File)
Jun 16 2026, 1:41 PM
Unknown Object (File)
Jun 13 2026, 7:51 AM
Unknown Object (File)
Jun 12 2026, 8:32 PM
Unknown Object (File)
Jun 11 2026, 9:44 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
jhb
wulf
Commits
rG17eaa359dcb5: ichiic: use bool for one-bit wide bit-fields
rG9f9b65a0933a: ichiic: use bool for one-bit wide bit-fields
rG87f55ab0b46a: ichiic: use bool for one-bit wide bit-fields
Summary

A one-bit wide bit-field can take only the values 0 and -1. Clang 16
introduced a warning that "implicit truncation from 'int' to a one-bit
wide bit-field changes value from 1 to -1". Fix by using c99 bool.

Reported by: Clang
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51011
Build 47902: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
dev/
ichiic/
4 lines
8 lines
4 lines
8 lines

Diff 120581

View Options

sys/dev/ichiic/ig4_acpi.c

Loading...
View Options

sys/dev/ichiic/ig4_iic.c

Loading...
View Options

sys/dev/ichiic/ig4_pci.c

Loading...
View Options

sys/dev/ichiic/ig4_var.h

Loading...