linuxkpi: Appease -Wunused-but-set-variable warnings from GCC.
ClosedPublic
Actions

Authored by jhb on Mar 30 2023, 11:33 PM.

Details

Reviewers

manu
• hselasky

Commits

rGad83dd2b2b6b: LinuxKPI: Appease -Wunused-but-set-variable warnings from GCC.

Summary

Mark assert dummy variables as __used.

Use a dummy (void) cast of the flags argument passed to spin_unlock_irqrestore so it gets treated as used.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50686
Build 47577: arc lint + arc unit

Event Timeline

jhb created this revision.Mar 30 2023, 11:33 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptMar 30 2023, 11:33 PM

jhb requested review of this revision.Mar 30 2023, 11:33 PM

Harbormaster completed remote builds in B50686: Diff 119685.Mar 30 2023, 11:33 PM

jhb added a child revision: D39350: fuse: Remove set but unused cr_gid variable..Mar 30 2023, 11:33 PM

LGTM but fix your commit message to say unused instead of used

This revision is now accepted and ready to land.Mar 31 2023, 5:13 AM

Commit message should start using: "LinuxKPI: "

Looks good!

• hselasky accepted this revision.Mar 31 2023, 9:44 AM

Closed by commit rGad83dd2b2b6b: LinuxKPI: Appease -Wunused-but-set-variable warnings from GCC. (authored by jhb). · Explain WhyMar 31 2023, 5:59 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGad83dd2b2b6b: LinuxKPI: Appease -Wunused-but-set-variable warnings from GCC..

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

kernel.h

2 lines

spinlock.h

1 line

Diff 119685

View Options

sys/compat/linuxkpi/common/include/linux/kernel.h