Differential D38677

cpuset: Adapt sched_affinity compat shims to the stable/13
ClosedPublic
Actions

Authored by dchagin on Feb 19 2023, 8:53 PM.

Tags

None

Referenced Files

	F166500382: D38677.id117642.diff
	Thu, Aug 13, 8:42 PM

	F166482967: D38677.id117618.diff
	Thu, Aug 13, 7:43 PM

	Unknown Object (File)
	Wed, Aug 12, 4:54 PM

	Unknown Object (File)
	Wed, Aug 12, 4:21 PM

	Unknown Object (File)
	Wed, Aug 12, 2:28 PM

	Unknown Object (File)
	Wed, Aug 12, 2:26 PM

	Unknown Object (File)
	Tue, Aug 11, 9:28 AM

	Unknown Object (File)
	Wed, Jul 29, 5:10 PM

Subscribers

Details

Reviewers

Commits

rG24a7d1392823: cpuset: Adapt sched_affinity compat shims to the stable/13

Summary

Use compat shims to run the stable/13 world on a kernels which
does not support CPU_WHICH_TIDPID.

This is direct commit to the stable/13.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin created this revision.Feb 19 2023, 8:53 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 19 2023, 8:53 PM

dchagin requested review of this revision.Feb 19 2023, 8:53 PM

Harbormaster completed remote builds in B49894: Diff 117599.Feb 19 2023, 8:53 PM

dchagin added a reviewer: kib.Feb 19 2023, 8:54 PM

dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

kib added inline comments.Feb 20 2023, 4:31 AM

lib/libc/gen/sched_getaffinity.c
44	I do not understand this condition. IMO the right fix would be to add (not replace) a symbol like P_OSREL_TIDPID_13 to stable/13 branch, and the condition would be if (__getosreldate() < P_OSREL_TIDPID_13 \|\| (P_OSREL_MAJOR(__getosreldate()) == P_OSREL_MAJOR(P_OSREL_TIDPID) && __getosreldate() < P_OSREL_TIDPID)) {

ok

Harbormaster completed remote builds in B49909: Diff 117618.Feb 20 2023, 8:40 AM

kib accepted this revision.Feb 20 2023, 12:26 PM

This revision is now accepted and ready to land.Feb 20 2023, 12:26 PM

Closed by commit rG24a7d1392823: cpuset: Adapt sched_affinity compat shims to the stable/13 (authored by dchagin). · Explain WhyFeb 20 2023, 5:29 PM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rG24a7d1392823: cpuset: Adapt sched_affinity compat shims to the stable/13.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

sched_getaffinity.c

6 lines

sched_setaffinity.c

6 lines

sys/

sys/

1 line

Diff 117642

lib/libc/gen/sched_getaffinity.c

Loading...

lib/libc/gen/sched_setaffinity.c

Loading...

sys/sys/param.h

Loading...