Details

Reviewers

bz
• hselasky
manu

Group Reviewers

linuxkpi

Commits

rG368a398b9c3e: LinuxKPI: return an address string in pci_name()
rG30960c51e646: LinuxKPI: return an address string in pci_name()
rG393b0ba25f1a: LinuxKPI: return an address string in pci_name()

Summary

amdgpu's virtual display feature uses pci_name to match a module parameter string, and the documentation shows an example of 0000:26:00.0 for the name.
In our case the name was just drmn, which is silly and not actually unique across devices. Let's generate the expected string.

Related to: https://github.com/freebsd/drm-kmod/issues/134
Sponsored by: https://www.patreon.com/valpackett

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49547
Build 46437: arc lint + arc unit

Event Timeline

val_packett.cool created this revision.Feb 11 2022, 2:18 PM

Herald added subscribers: linuxkpi, Contributor Reviews (src), emaste, imp. · View Herald TranscriptFeb 11 2022, 2:18 PM

val_packett.cool requested review of this revision.Feb 11 2022, 2:18 PM

Harbormaster completed remote builds in B44411: Diff 102657.Feb 11 2022, 2:18 PM

val_packett.cool added inline comments.Feb 11 2022, 2:20 PM

contrib/zlib-ng
1 ↗	(On Diff #102657)	hrm, how did git-arc add this o_0 this was not in the commit
sys/compat/linuxkpi/common/src/linux_pci.c
311	I think the first part is the domain but I'm not 100% sure…

val_packett.cool edited the summary of this revision. (Show Details)Feb 11 2022, 2:21 PM

val_packett.cool added reviewers: bz, • hselasky, manu, linuxkpi.

val_packett.cool added a project: linuxkpi.

val_packett.cool changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

Looks good.

sys/compat/linuxkpi/common/src/linux_pci.c
310	You don't need the "\" here. 4-space indent after line wrap.

Fix style

manu accepted this revision.Feb 11 2022, 2:55 PM

This revision is now accepted and ready to land.Feb 11 2022, 2:55 PM

I am fine with this; iwlwifi only uses the output as informational in dumping and nowhere else and none of my other drivers I was checking do use it.

I think the only thing to clarify before commit should be the MFC path (or not).

sys/compat/linuxkpi/common/include/linux/pci.h
264	Can we add this to the end or do we need to when doing an MFC? Or is this going to be MFCable at all? x11 ?
sys/compat/linuxkpi/common/src/linux_pci.c
280	Do we want to do the alloc game here or should we just use a static buffer? Because if alloc can fail, then we could still return device_get_desc() above in case path_name is NULL?