kboot: Parse memory usage
ClosedPublic
Actions

Authored by imp on Jan 29 2023, 3:17 PM.

Details

Reviewers

kevans
tsoome
manu

Commits

rG7da605ec03c1: kboot: Parse memory usage

Summary

To properly size segments, we have to know how much memory we have in
the system, as well as how much this process can allocate. Due to our
inability to overcommit, we need to know how much memory is
available. commit_limit is the grand total allowed. committed_as is the
current memory used. mem_avail is what Linux tells us is available. Find
these from /proc/meminfo. We'll use them later to allocate the biggest
possible segment sizes, but for now print the raw numbers.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49309
Build 46199: arc lint + arc unit

Event Timeline

imp created this revision.Jan 29 2023, 3:17 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 29 2023, 3:17 PM

Herald added subscribers: dab, emaste, andrew. · View Herald Transcript

imp requested review of this revision.Jan 29 2023, 3:17 PM

Harbormaster completed remote builds in B49309: Diff 116025.Jan 29 2023, 3:17 PM

imp added a parent revision: D38266: kboot: Don't need an arch pointer to get segments.Jan 29 2023, 3:17 PM

imp added a child revision: D38268: kboot: Trim initial allocation to 64MB.

imp retitled this revision from stand: Parse memory usage to kboot: Parse memory usage.Feb 1 2023, 11:14 PM

imp edited the summary of this revision. (Show Details)

rebase / refactor / redo

Harbormaster completed remote builds in B49441: Diff 116246.Feb 1 2023, 11:24 PM

kevans accepted this revision.Feb 2 2023, 4:01 AM

kevans added inline comments.

stand/kboot/main.c
53 ↗	(On Diff #116246)	`static` these for now? I /think/ the later use is isolated in main.c, probably another one to double-check against your branch
74 ↗	(On Diff #116246)	The indentation here seems to be a bit funky