Page MenuHomeFreeBSD
Differential D37970

netlink: improve RTM_GETADDR handling.
ClosedPublic
Actions

Authored by melifaro on Jan 6 2023, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 14, 6:57 PM
Unknown Object (File)
Sun, Apr 13, 4:17 AM
Unknown Object (File)
Sat, Apr 5, 1:15 AM
Unknown Object (File)
Feb 5 2025, 12:46 AM
Unknown Object (File)
Jan 30 2025, 3:04 PM
Unknown Object (File)
Jan 24 2025, 5:04 AM
Unknown Object (File)
Jan 19 2025, 9:41 PM
Unknown Object (File)
Jan 17 2025, 5:42 PM
View All 80 Files
Subscribers
ae
glebius
imp
pauamma_gundo.com

Details

Reviewers
pauamma_gundo.com
Group Reviewers
network
tests
manpages
Commits
rG74115922268c: netlink: improve RTM_GETADDR handling.
rGc1871a3372e3: netlink: improve RTM_GETADDR handling.
Summary
  • Allow filtering by ifa_family & ifa_index.
  • Add common RTM_<NEW|DEL|GET>ADDR parser
  • Add tests verifying RTM_GETADDR filtering behaviour & output
  • Factor out common netlink socket test methods into NetlinkTestTemplate
  • Add NLMSG_DONE message handler

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errortests/atf_python/sys/net/netlink.py:599E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:813E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:865E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:867E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:939E701PEP8 E701
Errortests/atf_python/sys/net/netlink.py:940E701PEP8 E701
Errortests/atf_python/sys/net/netlink.py:941E701PEP8 E701
Errortests/atf_python/sys/net/netlink.py:1015E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1131E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1136E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1147E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:1157E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:1157E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1160E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:1160E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1164E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:1433E203PEP8 E203
Errortests/sys/netlink/test_rtnl_iface.py:40E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:76E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:100E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:121E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:130E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:161E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:170E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:212E501PEP8 E501
Unit
No Test Coverage
Build Status
Buildable 48982
Build 45871: arc lint + arc unit

Event Timeline

melifaro created this revision.Jan 6 2023, 8:07 PM
Herald added subscribers: glebius, ae, imp. · View Herald TranscriptJan 6 2023, 8:07 PM
melifaro requested review of this revision.Jan 6 2023, 8:07 PM
Harbormaster completed remote builds in B48981: Diff 114807.Jan 6 2023, 8:07 PM
melifaro updated this revision to Diff 114808.Jan 6 2023, 8:12 PM

.

Harbormaster completed remote builds in B48982: Diff 114808.Jan 6 2023, 8:12 PM
melifaro edited the summary of this revision. (Show Details)Jan 6 2023, 8:13 PM
melifaro edited the test plan for this revision. (Show Details)
melifaro added reviewers: network, tests, manpages.
pauamma_gundo.com accepted this revision.Jan 6 2023, 8:22 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.

Fixable on commit if there are no other changes.

share/man/man4/rtnetlink.4
407
421

1 sentence = 1 line.

This revision is now accepted and ready to land.Jan 6 2023, 8:22 PM
This revision was landed with ongoing or failed builds.Jan 8 2023, 3:07 PM
Closed by commit rGc1871a3372e3: netlink: improve RTM_GETADDR handling. (authored by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rGc1871a3372e3: netlink: improve RTM_GETADDR handling..
melifaro added a commit: rG74115922268c: netlink: improve RTM_GETADDR handling..Jan 23 2023, 10:20 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
16 lines
sys/
netlink/
route/
87 lines
2 lines
tests/
atf_python/
sys/
net/
102 lines
sys/
netlink/
1 line
35 lines
144 lines

Diff 114808

View Options

share/man/man4/rtnetlink.4

Show All 20 Lines
# These categories has to match upstream categories. Don't invent # These categories has to match upstream categories. Don't invent
# your own. # your own.
# #
# builsystem is one of: # builsystem is one of:
# * autotools (default) # * autotools (default)
# * meson (experimental) # * meson (experimental)
# #
# #
# By defining USE_GITLAB and GL_COMMIT, it is possible to pull code straight # By defining USE_GITLAB and GL_TAGNAME, it is possible to pull code straight
diizzyUnsubmitted
Done
Inline Actions

This comment should be removed as we always prefer official release tarballs over generated ones.

diizzy: This comment should be removed as we always prefer official release tarballs over generated…
ziriasAuthorUnsubmitted
Done
Inline Actions

This just documents an actual feature of that helper, starting at line 87. I would only remove the comment if the feature was removed as well (and I don't know whether it is needed/used).

zirias: This just documents an actual feature of that helper, starting at line 87. I would only remove…
# from the freedesktop.org gitlab, instead of official release tarballs. # from the freedesktop.org gitlab, instead of official release tarballs.
# #
#.MAINTAINER: x11@FreeBSD.org #.MAINTAINER: x11@FreeBSD.org
.if !defined(_INCLUDE_USES_XORG_CAT_MK) .if !defined(_INCLUDE_USES_XORG_CAT_MK)
_INCLUDE_USES_XORG_CAT_MK=yes _INCLUDE_USES_XORG_CAT_MK=yes
_XORG_CATEGORIES= app data doc driver font lib proto util _XORG_CATEGORIES= app data doc driver font lib proto util
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines
View Options

sys/netlink/route/iface.c

Show All 20 Lines
# These categories has to match upstream categories. Don't invent # These categories has to match upstream categories. Don't invent
# your own. # your own.
# #
# builsystem is one of: # builsystem is one of:
# * autotools (default) # * autotools (default)
# * meson (experimental) # * meson (experimental)
# #
# #
# By defining USE_GITLAB and GL_COMMIT, it is possible to pull code straight # By defining USE_GITLAB and GL_TAGNAME, it is possible to pull code straight
diizzyUnsubmitted
Done
Inline Actions

This comment should be removed as we always prefer official release tarballs over generated ones.

diizzy: This comment should be removed as we always prefer official release tarballs over generated…
ziriasAuthorUnsubmitted
Done
Inline Actions

This just documents an actual feature of that helper, starting at line 87. I would only remove the comment if the feature was removed as well (and I don't know whether it is needed/used).

zirias: This just documents an actual feature of that helper, starting at line 87. I would only remove…
# from the freedesktop.org gitlab, instead of official release tarballs. # from the freedesktop.org gitlab, instead of official release tarballs.
# #
#.MAINTAINER: x11@FreeBSD.org #.MAINTAINER: x11@FreeBSD.org
.if !defined(_INCLUDE_USES_XORG_CAT_MK) .if !defined(_INCLUDE_USES_XORG_CAT_MK)
_INCLUDE_USES_XORG_CAT_MK=yes _INCLUDE_USES_XORG_CAT_MK=yes
_XORG_CATEGORIES= app data doc driver font lib proto util _XORG_CATEGORIES= app data doc driver font lib proto util
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines
View Options

sys/netlink/route/ifaddrs.h

Show All 20 Lines
# These categories has to match upstream categories. Don't invent # These categories has to match upstream categories. Don't invent
# your own. # your own.
# #
# builsystem is one of: # builsystem is one of:
# * autotools (default) # * autotools (default)
# * meson (experimental) # * meson (experimental)
# #
# #
# By defining USE_GITLAB and GL_COMMIT, it is possible to pull code straight # By defining USE_GITLAB and GL_TAGNAME, it is possible to pull code straight
diizzyUnsubmitted
Done
Inline Actions

This comment should be removed as we always prefer official release tarballs over generated ones.

diizzy: This comment should be removed as we always prefer official release tarballs over generated…
ziriasAuthorUnsubmitted
Done
Inline Actions

This just documents an actual feature of that helper, starting at line 87. I would only remove the comment if the feature was removed as well (and I don't know whether it is needed/used).

zirias: This just documents an actual feature of that helper, starting at line 87. I would only remove…
# from the freedesktop.org gitlab, instead of official release tarballs. # from the freedesktop.org gitlab, instead of official release tarballs.
# #
#.MAINTAINER: x11@FreeBSD.org #.MAINTAINER: x11@FreeBSD.org
.if !defined(_INCLUDE_USES_XORG_CAT_MK) .if !defined(_INCLUDE_USES_XORG_CAT_MK)
_INCLUDE_USES_XORG_CAT_MK=yes _INCLUDE_USES_XORG_CAT_MK=yes
_XORG_CATEGORIES= app data doc driver font lib proto util _XORG_CATEGORIES= app data doc driver font lib proto util
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines
View Options

tests/atf_python/sys/net/netlink.py

Show All 20 Lines
# These categories has to match upstream categories. Don't invent # These categories has to match upstream categories. Don't invent
# your own. # your own.
# #
# builsystem is one of: # builsystem is one of:
# * autotools (default) # * autotools (default)
# * meson (experimental) # * meson (experimental)
# #
# #
# By defining USE_GITLAB and GL_COMMIT, it is possible to pull code straight # By defining USE_GITLAB and GL_TAGNAME, it is possible to pull code straight
diizzyUnsubmitted
Done
Inline Actions

This comment should be removed as we always prefer official release tarballs over generated ones.

diizzy: This comment should be removed as we always prefer official release tarballs over generated…
ziriasAuthorUnsubmitted
Done
Inline Actions

This just documents an actual feature of that helper, starting at line 87. I would only remove the comment if the feature was removed as well (and I don't know whether it is needed/used).

zirias: This just documents an actual feature of that helper, starting at line 87. I would only remove…
# from the freedesktop.org gitlab, instead of official release tarballs. # from the freedesktop.org gitlab, instead of official release tarballs.
# #
#.MAINTAINER: x11@FreeBSD.org #.MAINTAINER: x11@FreeBSD.org
.if !defined(_INCLUDE_USES_XORG_CAT_MK) .if !defined(_INCLUDE_USES_XORG_CAT_MK)
_INCLUDE_USES_XORG_CAT_MK=yes _INCLUDE_USES_XORG_CAT_MK=yes
_XORG_CATEGORIES= app data doc driver font lib proto util _XORG_CATEGORIES= app data doc driver font lib proto util
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines
View Options

tests/sys/netlink/Makefile

Loading...
View Options

tests/sys/netlink/test_rtnl_iface.py

Loading...
View Options

tests/sys/netlink/test_rtnl_ifaddr.py

Loading...