Page MenuHomeFreeBSD
Differential D37764

iommu_gas: avoid overflow in bounds check
ClosedPublic
Actions

Authored by dougm on Dec 20 2022, 9:03 PM.
Tags
None
Referenced Files
F166970721: D37764.id114496.diff
Tue, Aug 18, 6:49 AM
F166931706: D37764.id114496.diff
Mon, Aug 17, 8:39 PM
F166921401: D37764.id114339.diff
Mon, Aug 17, 7:05 PM
Unknown Object (File)
Fri, Aug 14, 7:15 PM
Unknown Object (File)
Thu, Aug 13, 8:48 PM
Unknown Object (File)
Thu, Aug 13, 8:48 PM
Unknown Object (File)
Thu, Aug 13, 8:48 PM
Unknown Object (File)
Jul 17 2026, 1:07 AM
View All Files
Subscribers
imp

Details

Reviewers
andrew
alc
Commits
rG8765df60dc26: iommu_gas: avoid overflow in bounds check
rG5b9b55fbc432: iommu_gas: avoid overflow in bounds check
Summary

Change the range test in iommu_gas_match_one from '< ubound' to '<= ubound', and pass a smaller-by-one ubound parameter to it, to avoid overflow in ubound calculation.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm requested review of this revision.Dec 20 2022, 9:03 PM
dougm created this revision.
andrew accepted this revision.Dec 21 2022, 11:18 AM
This revision is now accepted and ready to land.Dec 21 2022, 11:18 AM
dougm updated this revision to Diff 114390.Dec 21 2022, 9:30 PM

Correct bounds check, where one was added when it should have been subtracted.

This revision now requires review to proceed.Dec 21 2022, 9:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 22 2022, 8:34 PM
Closed by commit rG5b9b55fbc432: iommu_gas: avoid overflow in bounds check (authored by dougm). · Explain Why
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rG5b9b55fbc432: iommu_gas: avoid overflow in bounds check.
Herald added a subscriber: imp. · View Herald TranscriptDec 22 2022, 8:34 PM
dougm added a commit: rG8765df60dc26: iommu_gas: avoid overflow in bounds check.Dec 25 2022, 7:02 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
iommu/
16 lines

Diff 114390

View Options

sys/dev/iommu/iommu_gas.c

Loading...