clang: Define NO_WDEPRECATED_NON_PROTOTYPE for clang 15
ClosedPublic
Actions

Authored by imp on Nov 28 2022, 7:39 AM.

Details

Reviewers

dim
jhb
emaste

Commits

rG4d2ea4dc2c7c: clang: Define NO_WDEPRECATED_NON_PROTOTYPE for clang 15
rG0ecb61619688: clang: Define NO_WDEPRECATED_NON_PROTOTYPE for clang 15

Summary

Clang 15 enforces function definitions using the C89 form rather than
the K&R form. While not strictly a prototype (which is only for a
declaration), use the name that mirror's clang's warning name. Much code
in contrib still uses K&R function definitions, so invent this for
compiling there.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48514
Build 45400: arc lint + arc unit

Event Timeline

imp created this revision.Nov 28 2022, 7:39 AM

Herald added subscribers: emaste, bdrewery. · View Herald TranscriptNov 28 2022, 7:39 AM

imp requested review of this revision.Nov 28 2022, 7:39 AM

Harbormaster completed remote builds in B48514: Diff 113548.Nov 28 2022, 7:39 AM

imp added reviewers: dim, jhb, emaste.Nov 28 2022, 7:41 AM

imp added a child revision: D37516: stand/zlib: Zlib still uses K&R function definitions.

jhb added inline comments.Nov 28 2022, 11:46 PM

share/mk/bsd.sys.mk
117	I would put this here maybe? I think in most other places we tend to sort these lists by compiler type first then version, so: clang 14 clang 15 clang 16 ... gcc 10 gcc 11 gcc 12 ...