Page MenuHomeFreeBSD

clang: Define NO_WDEPRECATED_NON_PROTOTYPE for clang 15
ClosedPublic

Authored by imp on Nov 28 2022, 7:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 12:17 AM
Unknown Object (File)
Tue, Nov 12, 12:15 PM
Unknown Object (File)
Oct 26 2024, 8:25 AM
Unknown Object (File)
Oct 10 2024, 3:14 PM
Unknown Object (File)
Oct 4 2024, 4:11 AM
Unknown Object (File)
Oct 2 2024, 2:06 PM
Unknown Object (File)
Sep 30 2024, 4:24 PM
Unknown Object (File)
Sep 20 2024, 5:20 AM
Subscribers

Details

Summary

Clang 15 enforces function definitions using the C89 form rather than
the K&R form. While not strictly a prototype (which is only for a
declaration), use the name that mirror's clang's warning name. Much code
in contrib still uses K&R function definitions, so invent this for
compiling there.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48562
Build 45448: arc lint + arc unit

Event Timeline

imp requested review of this revision.Nov 28 2022, 7:39 AM
share/mk/bsd.sys.mk
120

I would put this here maybe? I think in most other places we tend to sort these lists by compiler type first then version, so:

clang 14
clang 15
clang 16
...
gcc 10
gcc 11
gcc 12
...

share/mk/bsd.sys.mk
120

I was totally confused by your comment, and thought I'd get back to it later...
But I totally agree. You've found a mismerge I think.

This revision is now accepted and ready to land.Nov 30 2022, 5:00 PM