Differential D37516

stand/zlib: Zlib still uses K&R function definitions
ClosedPublic
Actions

Authored by imp on Nov 28 2022, 7:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 11, 1:34 AM

	Unknown Object (File)
	Sat, Oct 11, 1:34 AM

	Unknown Object (File)
	Sat, Oct 11, 1:34 AM

	Unknown Object (File)
	Sat, Oct 11, 1:34 AM

	Unknown Object (File)
	Fri, Oct 10, 6:53 PM

	Unknown Object (File)
	Fri, Sep 19, 8:20 AM

	Unknown Object (File)
	Sep 2 2025, 7:50 PM

	Unknown Object (File)
	Aug 15 2025, 9:14 AM

View All 83 Files

Subscribers

Details

Reviewers

manu
emaste
jhb

Commits

rG9ef73855542f: stand/zlib: Zlib still uses K&R function definitions
rG983a18021dec: stand/zlib: Zlib still uses K&R function definitions

Summary

So add ${NO_WDEPRECATED_NON_PROTOTYPE} to the CFLAGS of those
files. This can be removed when we import a zlib that's free of this
anachronism.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Nov 28 2022, 7:41 AM

Herald added a reviewer: manu. · View Herald TranscriptNov 28 2022, 7:41 AM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Nov 28 2022, 7:41 AM

imp added reviewers: emaste, jhb.Nov 28 2022, 7:42 AM

Harbormaster completed remote builds in B48515: Diff 113549.Nov 28 2022, 7:42 AM

imp added a parent revision: D37515: clang: Define NO_WDEPRECATED_NON_PROTOTYPE for clang 15.Nov 28 2022, 7:42 AM

jhb accepted this revision.Nov 28 2022, 11:46 PM

This revision is now accepted and ready to land.Nov 28 2022, 11:46 PM

Closed by commit rG983a18021dec: stand/zlib: Zlib still uses K&R function definitions (authored by imp). · Explain WhyNov 30 2022, 6:09 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG983a18021dec: stand/zlib: Zlib still uses K&R function definitions.

imp added a commit: rG9ef73855542f: stand/zlib: Zlib still uses K&R function definitions.Jan 24 2023, 10:19 PM

Revision Contents
Changeset List

Path

Size

stand/

libsa/

2 lines

Diff 113688

stand/libsa/Makefile

Loading...