Building the MADT table by basl will allow it to be loaded by qemu's
ACPI table loader.
This is the 14. patch required to merge D36983
Details
Details
- Reviewers
jhb markj rew - Group Reviewers
bhyve - Commits
- rG7f6f47151bde: bhyve: build MADT table by basl
rG897fe59adf7b: bhyve: build MADT table by basl
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 48229 Build 45115: arc lint + arc unit
Event Timeline
| usr.sbin/bhyve/acpi.c | ||
|---|---|---|
| 899 | This was ACTIVE_HIGH and TRIGGER_EDGE in the old version. | |
| usr.sbin/bhyve/acpi.c | ||
|---|---|---|
| 899 | Good catch. Thank you. | |
| usr.sbin/bhyve/acpi.c | ||
|---|---|---|
| 854 | For these I think it would be nicer to use the structures from actbl2.h such as ACPI_MADT_LOCAL_APIC. For example: for (int i = 0; i < basl_ncpu; ++i) {
ACPI_MADT_LOCAL_APIC local_apic;
local_apic.Header.Type = ACPI_MADT_TYPE_LOCAL_APIC;
local_apic.Header.Length = sizeof(local_apic);
local_apic.ProcessorId = i;
local_apic.Id = i;
local_apic.LapicFlags = htole32(ACPI_MADT_ENABLED);
BASL_EXEC(basl_table_append_bytes(madt, &local_apic, sizeof(local_apic));
} | |