Page MenuHomeFreeBSD
Differential D37185

ns8250: Fix sense of LSR_TEMT FCR check
ClosedPublic
Actions

Authored by cperciva on Oct 28 2022, 4:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 20, 4:19 AM
Unknown Object (File)
Fri, Sep 11, 12:52 PM
Unknown Object (File)
Tue, Sep 8, 10:31 PM
Unknown Object (File)
Tue, Sep 8, 2:11 PM
Unknown Object (File)
Tue, Sep 8, 7:22 AM
Unknown Object (File)
Sun, Sep 6, 12:37 AM
Unknown Object (File)
Sat, Sep 5, 9:58 PM
Unknown Object (File)
Sat, Sep 5, 9:17 PM
View All Files
Subscribers
None

Details

Reviewers
emaste
imp
jrtc27
Commits
rG5ad8c32c722b: ns8250: Fix sense of LSR_TEMT FCR check
Summary

When flushing the UART, we need to drain manually if LSR_TEMT is
*not* asserted, aka. if the transmit FIFO is not empty.

Reported by: void <void@f-m.fm>
Fixes: c4b68e7e53bb "ns8250: Check if flush via FCR succeeded"

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48064
Build 44951: arc lint + arc unit

Event Timeline

cperciva requested review of this revision.Oct 28 2022, 4:45 AM
cperciva created this revision.
Harbormaster completed remote builds in B48064: Diff 112316.Oct 28 2022, 4:45 AM
cperciva added a comment.Oct 28 2022, 7:20 PM

Tested by "void", confirmed that this eliminates the warning from his bhyve VMs.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 28 2022, 7:21 PM
Closed by commit rG5ad8c32c722b: ns8250: Fix sense of LSR_TEMT FCR check (authored by cperciva). · Explain Why
This revision was automatically updated to reflect the committed changes.
cperciva added a commit: rG5ad8c32c722b: ns8250: Fix sense of LSR_TEMT FCR check.

Revision Contents
Changeset List

PathSize
sys/
dev/
uart/
2 lines

Diff 112316

View Options

sys/dev/uart/uart_dev_ns8250.c

Loading...