ns8250: Fix sense of LSR_TEMT FCR check
ClosedPublic
Actions

Authored by cperciva on Oct 28 2022, 4:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 17, 10:20 AM

	Unknown Object (File)
	Fri, Oct 17, 8:53 AM

	Unknown Object (File)
	Aug 30 2025, 9:29 AM

	Unknown Object (File)
	Aug 14 2025, 9:26 AM

	Unknown Object (File)
	Aug 12 2025, 7:39 PM

	Unknown Object (File)
	Jul 20 2025, 10:36 AM

	Unknown Object (File)
	Jul 20 2025, 7:36 AM

	Unknown Object (File)
	Jul 20 2025, 7:05 AM

View All 68 Files

Subscribers

None

Details

Reviewers

emaste
imp
jrtc27

Commits

rG5ad8c32c722b: ns8250: Fix sense of LSR_TEMT FCR check

Summary

When flushing the UART, we need to drain manually if LSR_TEMT is
*not* asserted, aka. if the transmit FIFO is not empty.

Reported by: void <void@f-m.fm>
Fixes: c4b68e7e53bb "ns8250: Check if flush via FCR succeeded"

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva requested review of this revision.Oct 28 2022, 4:45 AM

cperciva created this revision.

Harbormaster completed remote builds in B48064: Diff 112316.Oct 28 2022, 4:45 AM

Tested by "void", confirmed that this eliminates the warning from his bhyve VMs.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 28 2022, 7:21 PM

Closed by commit rG5ad8c32c722b: ns8250: Fix sense of LSR_TEMT FCR check (authored by cperciva). · Explain Why

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rG5ad8c32c722b: ns8250: Fix sense of LSR_TEMT FCR check.

Revision Contents
Changeset List

Path

Size

sys/

dev/

uart/

uart_dev_ns8250.c

2 lines

Diff 112345

View Options

sys/dev/uart/uart_dev_ns8250.c

ns8250: Fix sense of LSR_TEMT FCR checkClosedPublicActions