Page MenuHomeFreeBSD
Differential D37061

inpcb: don't return INP_DROPPED entries from pcb lookups
ClosedPublic
Actions

Authored by glebius on Oct 19 2022, 10:22 PM.
Tags
None
Referenced Files
F147096357: D37061.diff
Sun, Mar 8, 7:36 AM
F147090546: D37061.id112784.diff
Sun, Mar 8, 6:21 AM
Unknown Object (File)
Fri, Mar 6, 5:38 AM
Unknown Object (File)
Fri, Mar 6, 4:59 AM
Unknown Object (File)
Wed, Mar 4, 4:50 PM
Unknown Object (File)
Sat, Feb 28, 11:19 PM
Unknown Object (File)
Wed, Feb 25, 12:00 AM
Unknown Object (File)
Tue, Feb 24, 5:06 PM
View All Files
Subscribers
imp
melifaro
tuexen

Details

Reviewers
tuexen
Group Reviewers
transport
Commits
rGf567d55f5152: inpcb: don't return INP_DROPPED entries from pcb lookups
Summary

The in_pcbdrop() KPI, which is used solely by TCP, allows to remove a
pcb from hash list and mark it as dropped. The comment suggests that
such pcb won't be returned by lookups. Indeed, every call to
in_pcblookup*() is accompanied by a check for INP_DROPPED. Do what
comment suggests: never return such pcbs and remove unnecessary checks.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47922
Build 44809: arc lint + arc unit

Event Timeline

glebius created this revision.Oct 19 2022, 10:22 PM
Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptOct 19 2022, 10:22 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
glebius requested review of this revision.Oct 19 2022, 10:22 PM
Harbormaster completed remote builds in B47922: Diff 112012.Oct 19 2022, 10:22 PM
tuexen added a subscriber: tuexen.Oct 19 2022, 10:38 PM
tuexen added inline comments.
sys/netinet/tcp_lro.c
1361

Maybe also remove the comment?

glebius added inline comments.Oct 19 2022, 10:43 PM
sys/netinet/tcp_lro.c
1361

It still applies to the (tp == NULL) check. Which is going to be addressed later, and that would remove the comment, too.

glebius added a child revision: D37062: tcp: inp_socket is valid through the lifetime of a TCP inpcb.Oct 19 2022, 10:51 PM
tuexen accepted this revision.Oct 20 2022, 9:27 AM
This revision is now accepted and ready to land.Oct 20 2022, 9:27 AM
glebius added a child revision: D37123: tcp: provide macros to access inpcb and socket from a tcpcb.Oct 25 2022, 6:20 PM
glebius added a child revision: D37127: tcp: embed inpcb into tcpcb.Oct 25 2022, 7:01 PM
Closed by commit rGf567d55f5152: inpcb: don't return INP_DROPPED entries from pcb lookups (authored by glebius). · Explain WhyNov 8 2022, 6:25 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGf567d55f5152: inpcb: don't return INP_DROPPED entries from pcb lookups.

Revision Contents
Changeset List

PathSize
sys/
netinet/
22 lines
11 lines
2 lines
12 lines

Diff 112012

View Options

sys/netinet/in_pcb.c

Loading...
View Options

sys/netinet/tcp_input.c

Loading...
View Options

sys/netinet/tcp_lro.c

Loading...
View Options

sys/netinet/tcp_subr.c

Loading...