Page MenuHomeFreeBSD
Differential D37027

inpcb: Remove a PCB from its LB group upon a subsequent error
ClosedPublic
Actions

Authored by markj on Oct 17 2022, 8:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 24, 7:28 AM
Unknown Object (File)
Mon, Mar 23, 4:50 PM
Unknown Object (File)
Mon, Mar 23, 9:52 AM
Unknown Object (File)
Sun, Mar 8, 1:18 AM
Unknown Object (File)
Feb 24 2026, 4:02 PM
Unknown Object (File)
Feb 21 2026, 4:56 AM
Unknown Object (File)
Feb 21 2026, 4:55 AM
Unknown Object (File)
Feb 18 2026, 8:38 AM
View All Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
glebius
Group Reviewers
network
Commits
rG0ea32f0e8376: inpcb: Remove a PCB from its LB group upon a subsequent error
rGa152dd863418: inpcb: Remove a PCB from its LB group upon a subsequent error
Summary

If a memory allocation failure causes bind to fail, we should take the
inpcb back out of its LB group since it's not prepared to handle
connections.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47864
Build 44751: arc lint + arc unit

Event Timeline

markj created this revision.Oct 17 2022, 8:39 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptOct 17 2022, 8:39 PM
markj requested review of this revision.Oct 17 2022, 8:39 PM
Harbormaster completed remote builds in B47864: Diff 111874.Oct 17 2022, 8:39 PM
markj added a parent revision: D37026: inpcb: Return an error when binding to an LB group if it is too large.Oct 17 2022, 8:39 PM
markj added a child revision: D37028: in6: Consolidate IN6_ARE_ADDR_EQUAL definitions.
glebius accepted this revision.Oct 18 2022, 4:31 AM

In the context of bind(2) we definitely can M_WAITOK. At what conditions is M_NOWAIT required?

This revision is now accepted and ready to land.Oct 18 2022, 4:31 AM
markj added a comment.Oct 18 2022, 1:49 PM
In D37027#840925, @glebius wrote:

In the context of bind(2) we definitely can M_WAITOK. At what conditions is M_NOWAIT required?

The inpcb mutex forces us to use M_NOWAIT here. Maybe those structures should be embedded in the port hash table instead. Though, right now we consume ~3MB per VNET jail for M_PCB mallocs.

Closed by commit rGa152dd863418: inpcb: Remove a PCB from its LB group upon a subsequent error (authored by markj). · Explain WhyNov 2 2022, 5:47 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGa152dd863418: inpcb: Remove a PCB from its LB group upon a subsequent error.
markj added a commit: rG0ea32f0e8376: inpcb: Remove a PCB from its LB group upon a subsequent error.Jan 22 2024, 6:45 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
17 lines

Diff 111874

View Options

sys/netinet/in_pcb.c

Loading...