inpcb: Return an error when binding to an LB group if it is too large
AcceptedPublic
Actions

Authored by markj on Oct 17 2022, 8:39 PM.

Tags

None

Referenced Files

	F171047666: D37026.id111873.diff
	Tue, Sep 8, 9:38 AM

	Unknown Object (File)
	Sat, Sep 5, 12:34 PM

	Unknown Object (File)
	Fri, Sep 4, 2:22 AM

	Unknown Object (File)
	Thu, Sep 3, 9:13 PM

	Unknown Object (File)
	Thu, Sep 3, 9:02 PM

	Unknown Object (File)
	Thu, Sep 3, 6:14 PM

	Unknown Object (File)
	Tue, Sep 1, 9:37 PM

	Unknown Object (File)
	Tue, Sep 1, 9:06 PM

Subscribers

Details

Reviewers

glebius

Group Reviewers

network

Summary

I think silently swallowing the error is wrong. Return an error
instead. Add a regression test to exercise this scenario.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47863
Build 44750: arc lint + arc unit

Event Timeline

markj created this revision.Oct 17 2022, 8:39 PM

Herald added subscribers: glebius, melifaro, asomers, imp. · View Herald TranscriptOct 17 2022, 8:39 PM

markj requested review of this revision.Oct 17 2022, 8:39 PM

Harbormaster completed remote builds in B47863: Diff 111873.Oct 17 2022, 8:39 PM

markj added a parent revision: D37025: inpcb: Remove checks for NULL credential references.Oct 17 2022, 8:39 PM

markj added a child revision: D37027: inpcb: Remove a PCB from its LB group upon a subsequent error.

No strong opinion or expertise here, but definitely swallowing error is bad. Should be MFC'ed too, imho.

This revision is now accepted and ready to land.Oct 18 2022, 4:28 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.c

2 lines

tests/

sys/

netinet/

so_reuseport_lb_test.c

48 lines

Diff 111873

View Options

sys/netinet/in_pcb.c