inpcb: Return an error when binding to an LB group if it is too large
AcceptedPublic
Actions

Authored by markj on Oct 17 2022, 8:39 PM.

Tags

None

Referenced Files

	F86670584: D37026.id111873.diff
	Sun, Jun 23, 6:48 PM

	Unknown Object (File)
	Sun, Jun 16, 6:13 PM

	Unknown Object (File)
	Sat, May 25, 10:04 AM

	Unknown Object (File)
	May 24 2024, 6:11 PM

	Unknown Object (File)
	Jan 31 2024, 12:54 PM

	Unknown Object (File)
	Jan 31 2024, 2:52 AM

	Unknown Object (File)
	Dec 20 2023, 7:14 AM

	Unknown Object (File)
	Nov 28 2023, 8:21 PM

Subscribers

Details

Reviewers

glebius

Group Reviewers

network

Summary

I think silently swallowing the error is wrong. Return an error
instead. Add a regression test to exercise this scenario.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47863
Build 44750: arc lint + arc unit

Event Timeline

markj created this revision.Oct 17 2022, 8:39 PM

Herald added subscribers: glebius, melifaro, asomers, imp. · View Herald TranscriptOct 17 2022, 8:39 PM

markj requested review of this revision.Oct 17 2022, 8:39 PM

Harbormaster completed remote builds in B47863: Diff 111873.Oct 17 2022, 8:39 PM

markj added a parent revision: D37025: inpcb: Remove checks for NULL credential references.Oct 17 2022, 8:39 PM

markj added a child revision: D37027: inpcb: Remove a PCB from its LB group upon a subsequent error.

No strong opinion or expertise here, but definitely swallowing error is bad. Should be MFC'ed too, imho.

This revision is now accepted and ready to land.Oct 18 2022, 4:28 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.c

2 lines

tests/

sys/

netinet/

so_reuseport_lb_test.c

48 lines

Diff 111873

View Options

sys/netinet/in_pcb.c