Differential D36571

stand: Create common/modinfo.h
ClosedPublic
Actions

Authored by imp on Sep 14 2022, 7:38 PM.

Tags

None

Referenced Files

	F167521191: D36571.diff
	Sat, Aug 22, 11:09 AM

	Unknown Object (File)
	Fri, Aug 21, 3:22 PM

	Unknown Object (File)
	Tue, Aug 18, 7:04 PM

	Unknown Object (File)
	Sun, Aug 16, 6:10 PM

	Unknown Object (File)
	Sat, Aug 15, 8:24 PM

	Unknown Object (File)
	Sat, Aug 15, 6:48 PM

	Unknown Object (File)
	Wed, Aug 12, 8:43 PM

	Unknown Object (File)
	Wed, Aug 12, 3:55 PM

Subscribers

Details

Reviewers

manu
kevans
tsoome

Group Reviewers

Commits

rG52804bde1baf: stand: Create common/modinfo.h
rGbca9c87b6104: stand: Create common/modinfo.h

Summary

Move all the MOD_xxx macros to this header. Each user of this interface
is currently required to define MOD_ALIGNMENT(l). modinfo was selected
because it sits inbetween modules and metadata and will make it easier
to migrate to new, shared intefaces.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47387
Build 44274: arc lint + arc unit

Event Timeline

imp created this revision.Sep 14 2022, 7:38 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 14 2022, 7:38 PM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript

imp requested review of this revision.Sep 14 2022, 7:38 PM

Harbormaster completed remote builds in B47387: Diff 110563.Sep 14 2022, 7:38 PM

imp added a child revision: D36572: stand: Move md_copymodules into modinfo.c and reduce copies.Sep 14 2022, 7:42 PM

imp added reviewers: kevans, tsoome.

imp added a parent revision: D36570: stand: Create MOD_ALIGN macro and use it everywhere.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2022, 3:54 PM

Closed by commit rGbca9c87b6104: stand: Create common/modinfo.h (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGbca9c87b6104: stand: Create common/modinfo.h.

imp added a commit: rG52804bde1baf: stand: Create common/modinfo.h.Jan 24 2023, 10:17 PM

Revision Contents
Changeset List

Path

Size

stand/

common/

61 lines

72 lines

efi/

loader/

66 lines

i386/

libi386/

59 lines

59 lines

userboot/

userboot/

58 lines

59 lines

Diff 110563

stand/common/metadata.c

Loading...

stand/common/modinfo.h

Loading...

stand/efi/loader/bootinfo.c

Loading...

stand/i386/libi386/bootinfo32.c

Loading...

stand/i386/libi386/bootinfo64.c

Loading...

stand/userboot/userboot/bootinfo32.c

Loading...

stand/userboot/userboot/bootinfo64.c

Loading...