Differential D36361

linuxolator: add netlink support
ClosedPublic
Actions

Authored by melifaro on Aug 26 2022, 2:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 3, 7:09 PM

	Unknown Object (File)
	Tue, Oct 28, 4:35 PM

	Unknown Object (File)
	Sat, Oct 25, 6:50 PM

	Unknown Object (File)
	Sat, Oct 25, 5:17 AM

	Unknown Object (File)
	Sat, Oct 25, 1:03 AM

	Unknown Object (File)
	Thu, Oct 23, 10:28 PM

	Unknown Object (File)
	Wed, Oct 22, 10:52 AM

	Unknown Object (File)
	Tue, Oct 21, 2:20 AM

Subscribers

Details

Reviewers

Group Reviewers

Linux Emulation

Commits

rGc1c40c8627a0: linuxolator: add netlink support
rG7c40e2d5f685: linuxolator: add netlink support

Summary

Compat part for running Linux binaries with Netlink ( D36002 ).

Test Plan

Please see testing section in D36002.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47241
Build 44128: arc lint + arc unit

Event Timeline

melifaro created this revision.Aug 26 2022, 2:59 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 26 2022, 2:59 PM

melifaro requested review of this revision.Aug 26 2022, 2:59 PM

Harbormaster completed remote builds in B47138: Diff 109874.Aug 26 2022, 2:59 PM

melifaro added a parent revision: D36002: netlink: add netlink support.Aug 26 2022, 3:00 PM

melifaro edited the summary of this revision. (Show Details)

melifaro edited the test plan for this revision. (Show Details)

melifaro added a reviewer: Linux Emulation.

emaste added a subscriber: emaste.Aug 28 2022, 11:40 PM

Update to recent -HEAD.

Harbormaster completed remote builds in B47241: Diff 110129.Sep 4 2022, 8:22 PM

mostly style, thank you! tested with 2.35 glibc tests suite, inet tests completed!

sys/compat/linux/linux_netlink.c
31	I suggest to add an empty line here
60	style, blank line, and in many functions below
120	unnecessary parentheses
130	the same here
166	may be use return (netlink_family != NETLINK_ROUTE ? hdr : rtnl_from_linux(hdr, npt)); ?
183	blank line
185	if (out_hdr != NULL) memcpy(out_hdr, hdr, hdr->nlmsg_len); return (out_hdr != NULL); ?
218	the same as above
234	unnecessary parentheses
385	unnecessary parentheses

dchagin accepted this revision.Sep 8 2022, 8:35 AM

This revision is now accepted and ready to land.Sep 8 2022, 8:35 AM

Update to reflect netlink KPI changes.

This revision now requires review to proceed.Sep 11 2022, 6:58 PM

Harbormaster completed remote builds in B47328: Diff 110448.Sep 11 2022, 6:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2022, 2:20 PM

Closed by commit rG7c40e2d5f685: linuxolator: add netlink support (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rG7c40e2d5f685: linuxolator: add netlink support.

melifaro added a commit: rGc1c40c8627a0: linuxolator: add netlink support.Jan 26 2023, 3:42 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

3 lines

13 lines

3 lines

linux_netlink.c

569 lines

6 lines

modules/

linux_common/

2 lines

Diff 110129

sys/compat/linux/linux.h

Loading...

sys/compat/linux/linux.c

Loading...

sys/compat/linux/linux_common.c

Loading...

sys/compat/linux/linux_netlink.c

Loading...

sys/compat/linux/linux_socket.c

Loading...

sys/modules/linux_common/Makefile

Loading...