Differential D35720

Improve usability of head(1) and tail(1):
ClosedPublic
Actions

Authored by delphij on Jul 6 2022, 7:32 AM.

Tags

None

Referenced Files

	F86303405: D35720.diff
	Tue, Jun 18, 11:20 AM

	Unknown Object (File)
	Thu, Jun 13, 4:29 AM

	Unknown Object (File)
	May 6 2024, 4:53 AM

	Unknown Object (File)
	May 6 2024, 4:53 AM

	Unknown Object (File)
	May 5 2024, 12:46 PM

	Unknown Object (File)
	May 3 2024, 4:00 AM

	Unknown Object (File)
	Apr 28 2024, 12:30 PM

	Unknown Object (File)
	Apr 28 2024, 12:30 PM

View All 51 Files

Subscribers

pauamma_gundo.com

Details

Reviewers

kevans
emaste
imp
pauamma_gundo.com
lwhsu

Group Reviewers

Commits

rG585762c3733f: Improve usability of head(1) and tail(1):
rG643ac419fafb: Improve usability of head(1) and tail(1):

Summary

Consistently support -q (quiet) and -v (verbose)
Allow specifying numbers with SI prefixes supported by expand_number(3)
Remove 2^31 limit on lines for head(1)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46346
Build 43235: arc lint + arc unit

Event Timeline

delphij created this revision.Jul 6 2022, 7:32 AM

Herald added a reviewer: manpages. · View Herald TranscriptJul 6 2022, 7:32 AM

Herald added a subscriber: imp. · View Herald Transcript

delphij requested review of this revision.Jul 6 2022, 7:32 AM

Harbormaster completed remote builds in B46276: Diff 107804.Jul 6 2022, 7:33 AM

delphij added a reviewer: imp.Jul 6 2022, 7:33 AM

lwhsu added a subscriber: lwhsu.Jul 7 2022, 6:47 AM

pauamma_gundo.com requested changes to this revision.Jul 8 2022, 10:05 PM

pauamma_gundo.com added a subscriber: pauamma_gundo.com.

pauamma_gundo.com added inline comments.

usr.bin/head/head.1
88–93	Moving these up to just under .It Fl n Ar count , Fl -lines Ns = Ns Ar count Print .Ar count lines of each of the specified files. would make for better flow IMO.

This revision now requires changes to proceed.Jul 8 2022, 10:05 PM

Update manual page per reviewer suggestion.

Harbormaster completed remote builds in B46335: Diff 107947.Jul 9 2022, 7:42 AM

The rendered page would be:

-c bytes, --bytes=bytes
        Print bytes of each of the specified files.

-n count, --lines=count
        Print count lines of each of the specified files.

        Both count and bytes may also be specified with size suffixes
        supported by expand_number(3).

(The indentation was somewhat weird in my opinion, does this look good, or do you have some suggestion in the markup?)

Looks good to me (carefully read the code, but didn't compile and execute it). It would be great if you can add some simple tests to guard those new features.

In D35720#811278, @delphij wrote:

(The indentation was somewhat weird in my opinion, does this look good, or do you have some suggestion in the markup?)

Good point. I don't know. Unless removing .Pp does the trick, someone more familiar with mdoc will have to answer.

Add test cases for new features.

Harbormaster completed remote builds in B46346: Diff 107969.Jul 9 2022, 7:38 PM

LGTM for the man page parts.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 13 2022, 4:14 AM

Closed by commit rG643ac419fafb: Improve usability of head(1) and tail(1): (authored by delphij). · Explain Why

This revision was automatically updated to reflect the committed changes.

delphij added a commit: rG643ac419fafb: Improve usability of head(1) and tail(1):.

des added a commit: rG585762c3733f: Improve usability of head(1) and tail(1):.Dec 13 2023, 8:09 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

head/

1 line

24 lines

33 lines

tests/

45 lines

tail/

1 line

2 lines

6 lines

25 lines

22 lines

tests/

44 lines

Diff 107969

usr.bin/head/Makefile

Loading...

usr.bin/head/head.1

Loading...

usr.bin/head/head.c

Loading...

usr.bin/head/tests/head_test.sh

Loading...

usr.bin/tail/Makefile

Loading...

usr.bin/tail/extern.h

Loading...

usr.bin/tail/forward.c

Loading...

usr.bin/tail/tail.1

Loading...

usr.bin/tail/tail.c

Loading...

usr.bin/tail/tests/tail_test.sh

Loading...