Page MenuHomeFreeBSD
Differential D35558

ACPI: change arguments to internal acpi_find_dsd()
ClosedPublic
Actions

Authored by bz on Jun 23 2022, 12:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 30, 1:28 AM
Unknown Object (File)
Sun, Dec 28, 10:52 AM
Unknown Object (File)
Wed, Dec 24, 7:01 AM
Unknown Object (File)
Dec 11 2025, 2:38 AM
Unknown Object (File)
Dec 2 2025, 11:23 AM
Unknown Object (File)
Dec 1 2025, 2:33 AM
Unknown Object (File)
Nov 24 2025, 1:29 PM
Unknown Object (File)
Nov 18 2025, 5:08 AM
View All Files
Subscribers
bag_semihalf.com
dsl
imp

Details

Reviewers
mw
manu
Commits
rGe4d7f82bf50a: ACPI: change arguments to internal acpi_find_dsd()
rG945eaca155fc: ACPI: change arguments to internal acpi_find_dsd()
Summary

acpi_find_dsd() is not a bus function and we only need the acpi_device (ad).
The only caller has already looked up the ad (from ivars) for us.
Directly pass the ad to acpi_find_dsd() instead of bus, dev and remove
the extra call to device_get_ivars(); the changed argument also means we
now call AcpiEvaluateObject directly on the handle.

This optimisation was done a while ago while debugging a driver which
passed a bad bus, dev combination making the old version fail.

MFC after: 2 weeks

Test Plan

Follow-up to b91fc6c43a81d / D31596

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46071
Build 42960: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
10 lines

Diff 107267

View Options

sys/dev/acpica/acpi.c

Loading...