Page MenuHomeFreeBSD
Differential D35453

bhyve nvme: Fix Controller init error cases
ClosedPublic
Actions

Authored by chuck on Jun 10 2022, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 6:37 PM
Unknown Object (File)
Fri, Oct 10, 6:37 PM
Unknown Object (File)
Fri, Oct 10, 6:37 PM
Unknown Object (File)
Fri, Oct 10, 6:37 PM
Unknown Object (File)
Fri, Oct 10, 1:36 PM
Unknown Object (File)
Wed, Oct 8, 8:30 AM
Unknown Object (File)
Mon, Oct 6, 11:58 PM
Unknown Object (File)
Wed, Oct 1, 11:29 AM
View All 87 Files
Subscribers
bcran
dab
rgrimes

Details

Reviewers
grehan
jhb
imp
Group Reviewers
bhyve
Commits
rG6c708e91f447: bhyve nvme: Fix Controller init error cases
rGd7d1becad4b6: bhyve nvme: Fix Controller init error cases
Summary

Fuzzing of bhyve uncovered an assertion failure in the NVMe emulation.
Investigation uncovered several corner cases the code did not handle.
This change handles several Controller initialization errors, including

  • bad AQ sizes
  • bad AQ vm_map_gpa
  • doorbell writes prior to RDY
  • doorbell writes to uninitialized queue
  • CSTS.RDY if CFS set

PR: 256317,256319,256320,256322
Reported by: Cheolwoo Myung <cwmyung@snu.ac.kr>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45939
Build 42827: arc lint + arc unit

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
55 lines

Diff 106833

View Options

usr.sbin/bhyve/pci_nvme.c

Loading...