Page MenuHomeFreeBSD
Differential D35403

LinuxKPI: Fix dmi_matches() function
ClosedPublic
Actions

Authored by • hselasky on Jun 5 2022, 11:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 11, 10:18 PM
Unknown Object (File)
Sat, May 11, 6:30 PM
Unknown Object (File)
Sat, May 11, 8:44 AM
Unknown Object (File)
Thu, May 9, 1:11 AM
Unknown Object (File)
Thu, May 9, 1:01 AM
Unknown Object (File)
Thu, May 9, 12:59 AM
Unknown Object (File)
Wed, May 8, 3:39 PM
Unknown Object (File)
Thu, May 2, 12:22 AM
View All 51 Files
Subscribers
emaste
imp

Details

Reviewers
manu
Group Reviewers
linuxkpi
Commits
rG85d7875d4291: LinuxKPI: Fix dmi_matches() function
Summary

Make sure we check for NULL pointers and also check all search criterias, not only the first one!

MFC after: 1 week
Sponsored by: NVIDIA Networking

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• hselasky created this revision.Jun 5 2022, 11:17 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptJun 5 2022, 11:17 AM
• hselasky requested review of this revision.Jun 5 2022, 11:17 AM
manu accepted this revision.Jun 6 2022, 7:58 AM

Thanks.
TBH we didn't tested with drm-kmod as I was sure that we used the version in linuxkpi_gplv2 but I was wrong and didn't correctly read the code.
Please bump FreeBSD_version so I can fix drm-kmod after to use fully this one.

This revision is now accepted and ready to land.Jun 6 2022, 7:58 AM
Closed by commit rG85d7875d4291: LinuxKPI: Fix dmi_matches() function (authored by • hselasky). · Explain WhyJun 6 2022, 8:32 AM
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rG85d7875d4291: LinuxKPI: Fix dmi_matches() function.
corvink mentioned this in rG6820a0512fa6: linuxkpi/dmi: don't match exactly on DMI_MATCH.Dec 8 2022, 12:42 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
19 lines
sys/
2 lines

Diff 106654

View Options

sys/compat/linuxkpi/common/src/linux_dmi.c

Loading...
View Options

sys/sys/param.h

Loading...