Page MenuHomeFreeBSD
Differential D35373

Use KERNEL_PANICKED() in more places
ClosedPublic
Actions

Authored by mhorne on May 31 2022, 6:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 19, 10:48 PM
Unknown Object (File)
Sun, Dec 28, 5:29 PM
Unknown Object (File)
Dec 12 2025, 4:36 PM
Unknown Object (File)
Nov 25 2025, 9:41 AM
Unknown Object (File)
Nov 10 2025, 5:28 AM
Unknown Object (File)
Nov 5 2025, 12:30 PM
Unknown Object (File)
Nov 3 2025, 1:14 PM
Unknown Object (File)
Oct 31 2025, 8:24 AM
View All 95 Files
Subscribers
imp

Details

Reviewers
markj
mjg
gnn
Commits
rG0db22efc9445: Use KERNEL_PANICKED() in more places
rG35eb9b10c265: Use KERNEL_PANICKED() in more places
Summary

This is slightly more optimized than checking panicstr directly. For
most of these instances performance doesn't matter, but let's make
KERNEL_PANICKED() the common idiom.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45798
Build 42686: arc lint + arc unit

Event Timeline

mhorne created this revision.May 31 2022, 6:16 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 31 2022, 6:16 PM
mhorne requested review of this revision.May 31 2022, 6:16 PM
Harbormaster completed remote builds in B45798: Diff 106518.May 31 2022, 6:16 PM
mjg accepted this revision.May 31 2022, 7:06 PM
This revision is now accepted and ready to land.May 31 2022, 7:06 PM
imp added inline comments.May 31 2022, 8:38 PM
sys/kern/subr_asan.c
390

So you didn't preserve the __predict_false here... but...

sys/kern/subr_msan.c
181

.... but you did here. Is there a reason for the difference?

mjg added inline comments.May 31 2022, 8:46 PM
sys/kern/subr_msan.c
181

the latter is a part of a bigger statement

i would argue the KERNEL_PANICKED || kdb_active thing should also be short-circuited into one macro which performs one branch

mhorne added inline comments.May 31 2022, 9:06 PM
sys/kern/subr_asan.c
390

It is not obvious from this review, but KERNEL_PANICKED() expands to __predict_false(panicked).

imp added inline comments.May 31 2022, 9:18 PM
sys/kern/subr_asan.c
390

Yea, I was wondering about the difference treatment... Though I misread the parens in at least one place.

Closed by commit rG35eb9b10c265: Use KERNEL_PANICKED() in more places (authored by mhorne). · Explain WhyJun 2 2022, 1:17 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG35eb9b10c265: Use KERNEL_PANICKED() in more places.
Herald added a reviewer: gnn. · View Herald TranscriptJun 2 2022, 1:17 PM
mhorne added a commit: rG0db22efc9445: Use KERNEL_PANICKED() in more places.Jun 23 2022, 10:23 PM

Revision Contents
Changeset List

PathSize
sys/
cddl/
contrib/
opensolaris/
uts/
common/
dtrace/
4 lines
dev/
hyperv/
storvsc/
2 lines
vt/
3 lines
kern/
8 lines
2 lines
4 lines

Diff 106518

View Options

sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c

Loading...
View Options

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

Loading...
View Options

sys/dev/vt/vt_core.c

Loading...
View Options

sys/kern/kern_shutdown.c

Loading...
View Options

sys/kern/subr_asan.c

Loading...
View Options

sys/kern/subr_msan.c

Loading...