Use KERNEL_PANICKED() in more places
ClosedPublic
Actions

Authored by mhorne on May 31 2022, 6:16 PM.

Details

Reviewers

markj
mjg
gnn

Commits

rG0db22efc9445: Use KERNEL_PANICKED() in more places
rG35eb9b10c265: Use KERNEL_PANICKED() in more places

Summary

This is slightly more optimized than checking panicstr directly. For
most of these instances performance doesn't matter, but let's make
KERNEL_PANICKED() the common idiom.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45798
Build 42686: arc lint + arc unit

Event Timeline

mhorne created this revision.May 31 2022, 6:16 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 31 2022, 6:16 PM

mhorne requested review of this revision.May 31 2022, 6:16 PM

Harbormaster completed remote builds in B45798: Diff 106518.May 31 2022, 6:16 PM

mjg accepted this revision.May 31 2022, 7:06 PM

This revision is now accepted and ready to land.May 31 2022, 7:06 PM

imp added inline comments.May 31 2022, 8:38 PM

sys/kern/subr_asan.c
390	So you didn't preserve the __predict_false here... but...
sys/kern/subr_msan.c
181	.... but you did here. Is there a reason for the difference?

mjg added inline comments.May 31 2022, 8:46 PM

sys/kern/subr_msan.c
181	the latter is a part of a bigger statement i would argue the KERNEL_PANICKED \|\| kdb_active thing should also be short-circuited into one macro which performs one branch