Page MenuHomeFreeBSD
Differential D35123

sockets: assert that any protocol with PR_RIGHTS has dom_dispose()
ClosedPublic
Actions

Authored by glebius on May 4 2022, 6:44 PM.
Tags
None
Referenced Files
F166611887: D35123.id105787.diff
Fri, Aug 14, 9:04 PM
F166611514: D35123.id105680.diff
Fri, Aug 14, 9:01 PM
F166611413: D35123.diff
Fri, Aug 14, 9:00 PM
Unknown Object (File)
Thu, Aug 13, 5:36 PM
Unknown Object (File)
Wed, Aug 12, 1:39 AM
Unknown Object (File)
Mon, Aug 10, 11:57 PM
Unknown Object (File)
Mon, Aug 10, 10:19 AM
Unknown Object (File)
Mon, Aug 10, 9:59 AM
View All Files
Subscribers
imp
markj

Details

Reviewers
markj
Group Reviewers
network
Commits
rGc17418a0ba6e: sockets: assert that any protocol with PR_RIGHTS has dom_dispose()
Summary

Through the entire history only PF_UNIX has this feature.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.May 4 2022, 6:44 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 4 2022, 6:44 PM
glebius requested review of this revision.May 4 2022, 6:44 PM
glebius added a child revision: D35124: sockets: don't call dom_dispose() on a listening socket.
Harbormaster completed remote builds in B45468: Diff 105680.May 4 2022, 6:45 PM
markj accepted this revision as: markj.May 4 2022, 7:11 PM
markj added a subscriber: markj.

I wouldn't bother with the assertions. If the pointer is null and we crash it'll be obvious why.

This revision is now accepted and ready to land.May 4 2022, 7:11 PM
glebius added a comment.May 4 2022, 7:16 PM

Just old memories of panic on "call NULL" looking unobvious what exactly happened. Probably no longer true for modern kernel.

Closed by commit rGc17418a0ba6e: sockets: assert that any protocol with PR_RIGHTS has dom_dispose() (authored by glebius). · Explain WhyMay 9 2022, 5:55 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGc17418a0ba6e: sockets: assert that any protocol with PR_RIGHTS has dom_dispose().

Revision Contents
Changeset List

PathSize
sys/
kern/
8 lines

Diff 105787

View Options

sys/kern/uipc_socket.c

Loading...