Page MenuHomeFreeBSD
Differential D35123

sockets: assert that any protocol with PR_RIGHTS has dom_dispose()
ClosedPublic
Actions

Authored by glebius on Wed, May 4, 6:44 PM.

Details

Reviewers
markj
Group Reviewers
network
Commits
R10:c17418a0ba6e: sockets: assert that any protocol with PR_RIGHTS has dom_dispose()
Summary

Through the entire history only PF_UNIX has this feature.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

glebius created this revision.Wed, May 4, 6:44 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, May 4, 6:44 PM
glebius requested review of this revision.Wed, May 4, 6:44 PM
glebius added a child revision: D35124: sockets: don't call dom_dispose() on a listening socket.
Harbormaster completed remote builds in B45468: Diff 105680.Wed, May 4, 6:45 PM
markj accepted this revision as: markj.Wed, May 4, 7:11 PM
markj added a subscriber: markj.

I wouldn't bother with the assertions. If the pointer is null and we crash it'll be obvious why.

This revision is now accepted and ready to land.Wed, May 4, 7:11 PM
glebius added a comment.Wed, May 4, 7:16 PM

Just old memories of panic on "call NULL" looking unobvious what exactly happened. Probably no longer true for modern kernel.

Closed by commit R10:c17418a0ba6e: sockets: assert that any protocol with PR_RIGHTS has dom_dispose() (authored by glebius). · Explain WhyMon, May 9, 5:55 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: R10:c17418a0ba6e: sockets: assert that any protocol with PR_RIGHTS has dom_dispose().

Revision Contents
Changeset List

PathSize
sys/
kern/
8 lines

Diff 105787

View Options

sys/kern/uipc_socket.c

Loading...