sockets: assert that any protocol with PR_RIGHTS has dom_dispose()

[glebius]

Summary

Through the entire history only PF_UNIX has this feature.

[markj]

I wouldn't bother with the assertions. If the pointer is null and we crash it'll be obvious why.

[glebius]

Just old memories of panic on "call NULL" looking unobvious what exactly happened. Probably no longer true for modern kernel.

sys/kern/uipc_socket.c

if (devname != NULL) {
                          *       these in pcmchan::caps?
                          */
                         ai->caps = PCM_CAP_REALTIME | PCM_CAP_MMAP | PCM_CAP_TRIGGER |
                             ((ch->flags & CHN_F_VIRTUAL) ? PCM_CAP_VIRTUAL : 0) |
                             ((ch->direction == PCMDIR_PLAY) ? PCM_CAP_OUTPUT : PCM_CAP_INPUT);
 
                         /*
                          * Collect formats supported @b natively by the
-                         * device.  Also determine min/max channels.  (I.e.,
-                         * mono, stereo, or both?)
-                         *
-                         * If any channel is stereo, maxch = 2;
-                         * if all channels are stereo, minch = 2, too;
-                         * if any channel is mono, minch = 1;
-                         * and if all channels are mono, maxch = 1.
+                         * device.  Also determine min/max channels.
                          */
                         minch = INT_MAX;
                         maxch = 0;
                         fmts = 0;
                         for (i = 0; caps->fmtlist[i]; i++) {
                                 fmts |= AFMT_ENCODING(caps->fmtlist[i]);
                                 minch = min(AFMT_CHANNEL(caps->fmtlist[i]), minch);
                                 maxch = max(AFMT_CHANNEL(caps->fmtlist[i]), maxch);