sockets: assert that any protocol with PR_RIGHTS has dom_dispose()
ClosedPublic
Actions

Authored by glebius on May 4 2022, 6:44 PM.

Tags

None

Referenced Files

	F166969165: D35123.id105787.diff
	Tue, Aug 18, 6:31 AM

	F166930855: D35123.id105787.diff
	Mon, Aug 17, 8:36 PM

	F166908975: D35123.id105680.diff
	Mon, Aug 17, 5:03 PM

	Unknown Object (File)
	Sun, Aug 16, 8:15 PM

	Unknown Object (File)
	Sun, Aug 16, 7:49 PM

	Unknown Object (File)
	Sat, Aug 15, 7:48 PM

	Unknown Object (File)
	Fri, Aug 14, 9:04 PM

	Unknown Object (File)
	Fri, Aug 14, 9:01 PM

View All Files

Subscribers

imp

markj

Details

Reviewers

markj

Group Reviewers

network

Commits

rGc17418a0ba6e: sockets: assert that any protocol with PR_RIGHTS has dom_dispose()

Summary

Through the entire history only PF_UNIX has this feature.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45468
Build 42356: arc lint + arc unit

Event Timeline

glebius created this revision.May 4 2022, 6:44 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 4 2022, 6:44 PM

glebius requested review of this revision.May 4 2022, 6:44 PM

glebius added a child revision: D35124: sockets: don't call dom_dispose() on a listening socket.

Harbormaster completed remote builds in B45468: Diff 105680.May 4 2022, 6:45 PM

I wouldn't bother with the assertions. If the pointer is null and we crash it'll be obvious why.

This revision is now accepted and ready to land.May 4 2022, 7:11 PM

Just old memories of panic on "call NULL" looking unobvious what exactly happened. Probably no longer true for modern kernel.

Closed by commit rGc17418a0ba6e: sockets: assert that any protocol with PR_RIGHTS has dom_dispose() (authored by glebius). · Explain WhyMay 9 2022, 5:55 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGc17418a0ba6e: sockets: assert that any protocol with PR_RIGHTS has dom_dispose().

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_socket.c

8 lines

Diff 105680

View Options

sockets: assert that any protocol with PR_RIGHTS has dom_dispose()ClosedPublicActions