Page MenuHomeFreeBSD
Differential D34863

bhyve/snapshot: ..back to SOCK_STREAM
ClosedPublic
Actions

Authored by rew on Apr 10 2022, 5:15 AM.
Tags
None
Referenced Files
F153997374: D34863.id105528.diff
Sat, Apr 25, 8:26 AM
F153994419: D34863.id105368.diff
Sat, Apr 25, 7:56 AM
Unknown Object (File)
Thu, Apr 16, 4:18 PM
Unknown Object (File)
Thu, Apr 16, 12:20 PM
Unknown Object (File)
Mon, Apr 13, 8:18 PM
Unknown Object (File)
Sat, Apr 11, 4:24 AM
Unknown Object (File)
Sat, Apr 11, 1:53 AM
Unknown Object (File)
Fri, Apr 10, 10:07 PM
View All Files
Subscribers
bcran
evgueni.gavrilov_itglobal.com
imp
jhb
markj
rgrimes

Details

Reviewers
markj
Group Reviewers
bhyve
Commits
rG10e30f7d8fcb: bhyve/snapshot: ..back to SOCK_STREAM
rG690b7ea08179: bhyve/snapshot: ..back to SOCK_STREAM
Summary

Now that nvlist_send()/nvlist_recv() are being used, ditch the datagram
socket.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45359
Build 42247: arc lint + arc unit

Event Timeline

rew created this revision.Apr 10 2022, 5:15 AM
Herald added a reviewer: bhyve. · View Herald TranscriptApr 10 2022, 5:15 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
rew requested review of this revision.Apr 10 2022, 5:15 AM
Harbormaster completed remote builds in B45102: Diff 104832.Apr 10 2022, 5:16 AM
jhb added a subscriber: jhb.Apr 12 2022, 10:16 PM
jhb added inline comments.
usr.sbin/bhyvectl/bhyvectl.c
1702

I think you still want SUN_LEN here? (And do we need to set addr.sun_len as well?)

evgueni.gavrilov_itglobal.com added a subscriber: evgueni.gavrilov_itglobal.com.Apr 21 2022, 12:23 PM
rew updated this revision to Diff 105368.Apr 24 2022, 4:18 PM

feedback from jhb..use SUN_LEN()

Harbormaster completed remote builds in B45341: Diff 105368.Apr 24 2022, 4:18 PM
markj added a subscriber: markj.Apr 25 2022, 3:27 PM
markj added inline comments.
usr.sbin/bhyve/snapshot.c
1460–1461

Isn't the socket leaked?

usr.sbin/bhyvectl/bhyvectl.c
1702–1703

Wrap this line since you're modifying it anyway?

rew updated this revision to Diff 105401.Apr 25 2022, 4:02 PM

address feedback from markj:

  • wrap long line
  • close file descriptor being leaked
Harbormaster completed remote builds in B45359: Diff 105401.Apr 25 2022, 4:02 PM
markj accepted this revision as: markj.Apr 25 2022, 5:38 PM
This revision is now accepted and ready to land.Apr 25 2022, 5:38 PM
Closed by commit rG690b7ea08179: bhyve/snapshot: ..back to SOCK_STREAM (authored by rew). · Explain WhyApr 28 2022, 3:45 PM
This revision was automatically updated to reflect the committed changes.
rew added a commit: rG690b7ea08179: bhyve/snapshot: ..back to SOCK_STREAM.
jhb added a commit: rG10e30f7d8fcb: bhyve/snapshot: ..back to SOCK_STREAM.Jan 26 2023, 6:56 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
14 lines
bhyvectl/
9 lines

Diff 105401

View Options

usr.sbin/bhyve/snapshot.c

Loading...
View Options

usr.sbin/bhyvectl/bhyvectl.c

Loading...