Differential D35011

KTLS: Move OCF function pointers out of ktls_session.
ClosedPublic
Actions

Authored by jhb on Apr 20 2022, 9:09 PM.

Tags

None

Referenced Files

	F152678865: D35011.diff
	Thu, Apr 16, 11:40 AM

	F152672431: D35011.id105314.diff
	Thu, Apr 16, 10:45 AM

	Unknown Object (File)
	Wed, Apr 15, 11:04 PM

	Unknown Object (File)
	Tue, Apr 14, 11:40 AM

	Unknown Object (File)
	Sun, Apr 12, 10:01 PM

	Unknown Object (File)
	Thu, Mar 26, 1:28 AM

	Unknown Object (File)
	Tue, Mar 24, 9:35 PM

	Unknown Object (File)
	Thu, Mar 19, 3:20 AM

Subscribers

Details

Reviewers

gallatin
• hselasky

Commits

rGa4c5d490f6be: KTLS: Move OCF function pointers out of ktls_session.

Summary

Instead, create a switch structure private to ktls_ocf.c and store a
pointer to the switch in the ocf_session. This will permit adding an
additional function pointer needed for NIC TLS RX without further
bloating ktls_session.

Sponsored by: Netflix

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45283
Build 42171: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 20 2022, 9:09 PM

Herald added subscribers: jmg, imp. · View Herald TranscriptApr 20 2022, 9:09 PM

jhb requested review of this revision.Apr 20 2022, 9:09 PM

Harbormaster completed remote builds in B45283: Diff 105241.Apr 20 2022, 9:09 PM

jhb added a child revision: D35012: KTLS: Add a new recrypt operation to the software backend..Apr 20 2022, 9:10 PM

jhb retitled this revision from Move OCF function pointers out of ktls_session. to KTLS: Move OCF function pointers out of ktls_session..Apr 20 2022, 9:14 PM

Maybe use "const". Else looks good!

sys/opencrypto/ktls_ocf.c
63	const struct ktls_ocf_sw *sw; ??
552	static const ?

This revision is now accepted and ready to land.Apr 21 2022, 6:00 AM

jhb marked 2 inline comments as done.Apr 21 2022, 6:06 PM

Sprinkle some const.

This revision now requires review to proceed.Apr 21 2022, 8:47 PM

Harbormaster completed remote builds in B45311: Diff 105314.Apr 21 2022, 8:47 PM

• hselasky accepted this revision.Apr 22 2022, 6:38 AM

This revision is now accepted and ready to land.Apr 22 2022, 6:38 AM

Closed by commit rGa4c5d490f6be: KTLS: Move OCF function pointers out of ktls_session. (authored by jhb). · Explain WhyApr 22 2022, 10:55 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGa4c5d490f6be: KTLS: Move OCF function pointers out of ktls_session..

Revision Contents
Changeset List

Path

Size

sys/

kern/

6 lines

opencrypto/

6 lines

60 lines

sys/

10 lines

Diff 105241

sys/kern/uipc_ktls.c

Loading...

sys/opencrypto/ktls.h

Loading...

sys/opencrypto/ktls_ocf.c

Loading...

sys/sys/ktls.h

Loading...