Differential D34866

nvme: Fix old intel alignment size
ClosedPublic
Actions

Authored by imp on Apr 10 2022, 5:11 PM.

Tags

None

Referenced Files

	F149002832: D34866.diff
	Sat, Mar 21, 4:41 PM

	Unknown Object (File)
	Tue, Mar 3, 2:33 AM

	Unknown Object (File)
	Feb 14 2026, 7:00 AM

	Unknown Object (File)
	Jan 16 2026, 2:34 AM

	Unknown Object (File)
	Jan 15 2026, 7:57 PM

	Unknown Object (File)
	Jan 9 2026, 2:42 PM

	Unknown Object (File)
	Jan 8 2026, 9:20 AM

	Unknown Object (File)
	Jan 6 2026, 1:35 PM

Subscribers

Details

Reviewers

mav
chuck
gallatin
chs
andrew
jimharris
rpokala

Commits

rGa7218e7a6b05: nvme: Fix old intel alignment size

Summary

The intel raid stripe alignment parameter is based on CAP.MPSMIN, so use
that directly now that we have it available.

Sponsored by: Netflix

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45153
Build 42041: arc lint + arc unit

Event Timeline

imp created this revision.Apr 10 2022, 5:11 PM

Herald added a subscriber: dab. · View Herald TranscriptApr 10 2022, 5:11 PM

imp requested review of this revision.Apr 10 2022, 5:11 PM

Harbormaster completed remote builds in B45107: Diff 104842.Apr 10 2022, 5:11 PM

imp added a parent revision: D34865: nvme: Define NVME_MPS_SHIFT.Apr 10 2022, 5:11 PM

imp added a child revision: D34867: nvme: Base maximum data transfer size directly on MPSMIN in cap_hi.

rew added a subscriber: rew.Apr 14 2022, 12:30 AM

rew added inline comments.

sys/dev/nvme/nvme_ns.c

got the following error when building:

--- nvme_ns.o ---
 /usr/src/sys/dev/nvme/nvme_ns.c:578:50: error: operator '<<' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wshift-op-parentheses]
                        (1 << ctrlr->cdata.vs[3] + NVME_MPS_SHIFT +
                           ~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
/usr/src/sys/dev/nvme/nvme_ns.c:578:50: note: place parentheses around the '+' expression to silence this warning
                        (1 << ctrlr->cdata.vs[3] + NVME_MPS_SHIFT +
                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
1 error generated.
*** [nvme_ns.o] Error code 1

fix precidence error

Harbormaster completed remote builds in B45153: Diff 104980.Apr 14 2022, 12:57 AM

imp added inline comments.Apr 14 2022, 12:58 AM

sys/dev/nvme/nvme_ns.c
578–579	Oh, right. I think I've fixed that in my tree... Oh, I didn't commit it and the change was lost... Good catch! thanks! I've updated

chuck accepted this revision.Apr 14 2022, 3:08 PM

This revision is now accepted and ready to land.Apr 14 2022, 3:08 PM

Closed by commit rGa7218e7a6b05: nvme: Fix old intel alignment size (authored by imp). · Explain WhyApr 15 2022, 8:48 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGa7218e7a6b05: nvme: Fix old intel alignment size.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

10 lines

Diff 104980

sys/dev/nvme/nvme_ns.c

Loading...