Differential D34297

linuxkpi: Add mmap_lock.h
ClosedPublic
Actions

Authored by manu on Feb 16 2022, 10:29 AM.

Tags

None

Referenced Files

	F81575783: D34297.diff
	Thu, Apr 18, 8:51 AM

	Unknown Object (File)
	Tue, Apr 16, 5:58 AM

	Unknown Object (File)
	Feb 7 2024, 9:24 PM

	Unknown Object (File)
	Jan 15 2024, 5:02 AM

	Unknown Object (File)
	Dec 24 2023, 6:07 AM

	Unknown Object (File)
	Dec 20 2023, 6:50 AM

	Unknown Object (File)
	Dec 15 2023, 4:14 AM

	Unknown Object (File)
	Dec 12 2023, 7:06 AM

View All 33 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG61b0043efb8c: linuxkpi: Add mmap_lock.h
rG995c3b88d485: linuxkpi: Add mmap_lock.h

Summary

This contain mmap_read_lock, mmap_read_unlock and mmap_write_lock_killable
which are abstraction around down_read, up_read and down_write_killable.
Note that in Linux 5.8 mmap_sem was renamed to mmap_lock.
We might want to do the same at some point but some drivers still uses
the old mmap locking API.

MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.Feb 16 2022, 10:29 AM

Herald added a subscriber: emaste. · View Herald TranscriptFeb 16 2022, 10:29 AM

manu requested review of this revision.Feb 16 2022, 10:29 AM

wulf added a subscriber: wulf.Feb 16 2022, 10:39 AM

wulf added inline comments.

sys/compat/linuxkpi/common/include/linux/mm_types.h
48	Can anonymous union be used to handle both names?

manu added inline comments.Feb 16 2022, 10:42 AM

sys/compat/linuxkpi/common/include/linux/mm_types.h
48	Probably yes but using the new API I think that you're not supposed to use or know the underlying name.

Otherwise looks okay to me.

sys/compat/linuxkpi/common/include/linux/mmap_lock.h
30	{{{ #include <linux/mm_types.h> #include <linux/rwsem.h> }}}

manu updated this revision to Diff 102836.Feb 16 2022, 1:40 PM

manu marked an inline comment as done.

bz accepted this revision as: bz.Feb 16 2022, 1:45 PM

This revision is now accepted and ready to land.Feb 16 2022, 1:45 PM

Closed by commit rG995c3b88d485: linuxkpi: Add mmap_lock.h (authored by manu). · Explain WhyFeb 17 2022, 8:45 AM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG995c3b88d485: linuxkpi: Add mmap_lock.h.

Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2022, 8:45 AM

manu added a commit: rG61b0043efb8c: linuxkpi: Add mmap_lock.h.Mar 5 2022, 11:35 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

1 line

1 line

54 lines

Diff 102836

sys/compat/linuxkpi/common/include/linux/mm.h

Loading...

sys/compat/linuxkpi/common/include/linux/mm_types.h

Loading...

sys/compat/linuxkpi/common/include/linux/mmap_lock.h

Loading...