generally I like it. I like the idea of making default verbosity 2, and printing the ELF_VERBOSE stuff at level 3 and ditching that #ifdef.

Might I suggest something like this next to the definition of module_verbose:

enum {
        MODULE_VERBOSE_SILENT,  /* 0 */
        MODULE_VERBOSE_QUIET,   /* 1 */
        MODULE_VERBOSE_DEFAULT, /* 2 */
        MODULE_VERBOSE_FULL,    /* 3 */
};

Or something along those lines. Then, rather than comparing against bare 0 or 2 (or potentially 3, as you mentioned here in Phabricator), you'd compare against the symbol. And of course get rid of MODULE_VERBOSE in favor of MODULE_VERBOSE_DEFAULT.

In D34245#774880, @rpokala wrote:

Might I suggest something like this next to the definition of module_verbose:

enum {
        MODULE_VERBOSE_SILENT,  /* 0 */
        MODULE_VERBOSE_QUIET,   /* 1 */
        MODULE_VERBOSE_DEFAULT, /* 2 */
        MODULE_VERBOSE_FULL,    /* 3 */
};

Or something along those lines. Then, rather than comparing against bare 0 or 2 (or potentially 3, as you mentioned here in Phabricator), you'd compare against the symbol. And of course get rid of MODULE_VERBOSE in favor of MODULE_VERBOSE_DEFAULT.

The point of the #define is to allow build time control of the default, I'm building my loader.efi with -DMODULE_VERBOSE=0

LGTM

in general, I'd propose that we use >= or > for the test rather than == or != to avoid encoding knowledge about the levels.

In D34245#775302, @imp wrote:

in general, I'd propose that we use >= or > for the test rather than == or != to avoid encoding knowledge about the levels.

So we could, for example, have a FULLER :)