Page MenuHomeFreeBSD
Differential D34127

LRO code should deal with all 12 TCP header flags
ClosedPublic
Actions

Authored by rscheff on Feb 1 2022, 2:44 PM.
Tags
None
Referenced Files
F103986729: D34127.diff
Mon, Dec 2, 1:35 AM
Unknown Object (File)
Sep 23 2024, 2:29 AM
Unknown Object (File)
Sep 23 2024, 2:29 AM
Unknown Object (File)
Sep 23 2024, 2:29 AM
Unknown Object (File)
Sep 23 2024, 2:29 AM
Unknown Object (File)
Sep 23 2024, 2:17 AM
Unknown Object (File)
Sep 9 2024, 1:27 PM
Unknown Object (File)
Sep 5 2024, 4:54 PM
View All 42 Files
Subscribers
imp
melifaro

Details

Reviewers
• hselasky
rrs
glebius
tuexen
jtl
Group Reviewers
NetApp
transport
Commits
rG93e28d6e89e9: tcp: LRO code to deal with all 12 TCP header flags
Summary

RFC793 has 4 reserved flag bits for future use. One of those
bits used to be assigned to ECN Nonce (now historic), and
may be reused for AccurateECN.

This patch is to include these bits in the LRO code to ease
the extensibility if/when these bits are used.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rscheff created this revision.Feb 1 2022, 2:44 PM
Herald added a reviewer: transport. · View Herald TranscriptFeb 1 2022, 2:44 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
rscheff requested review of this revision.Feb 1 2022, 2:44 PM
Harbormaster completed remote builds in B44219: Diff 102214.Feb 1 2022, 2:44 PM
• hselasky added inline comments.Feb 1 2022, 3:13 PM
sys/netinet/tcp_lro.h
151

Maybe you should add a "reserved : 2", so that the bitfields fill the 16- bits available.

• hselasky accepted this revision.Feb 1 2022, 3:14 PM

Looks good.

rscheff updated this revision to Diff 102216.Feb 1 2022, 3:21 PM
  • add comments and reserve remainder of bitfield
Harbormaster completed remote builds in B44221: Diff 102216.Feb 1 2022, 3:21 PM
rscheff marked an inline comment as done.Feb 1 2022, 3:23 PM
• hselasky added inline comments.Feb 1 2022, 3:25 PM
sys/netinet/tcp_lro.c
924

Maybe a macro to do exactly this would be at its place?

#define TCP_GET_FLAGS(th) (((th)->th_x2 << 8) | ((th)->th_flags))

--HPS

rscheff added inline comments.Feb 1 2022, 3:29 PM
sys/netinet/tcp_lro.c
924

A good idea. But I would do that as a separate Diff, as there are (already) a couple places scattered across the base stack, where this would come in handy...

rrs added a comment.Feb 1 2022, 3:30 PM

This looks good but I want to pull it down and see if it will compile ;)

rrs accepted this revision.Feb 1 2022, 3:38 PM
This revision is now accepted and ready to land.Feb 1 2022, 3:38 PM
Closed by commit rG93e28d6e89e9: tcp: LRO code to deal with all 12 TCP header flags (authored by rscheff). · Explain WhyFeb 1 2022, 6:00 PM
This revision was automatically updated to reflect the committed changes.
rscheff added a commit: rG93e28d6e89e9: tcp: LRO code to deal with all 12 TCP header flags.

Revision Contents
Changeset List

PathSize
sys/
netinet/
4 lines
17 lines
10 lines

Diff 102226

View Options

sys/netinet/tcp.h

Loading...
View Options

sys/netinet/tcp_lro.h

Loading...
View Options

sys/netinet/tcp_lro.c

Loading...