rescue: Link with -lncursesw instead of -lncursesw_real.
ClosedPublic
Actions

Authored by jhb on Feb 1 2022, 1:08 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 18, 11:03 AM

	Unknown Object (File)
	Wed, Nov 5, 11:05 PM

	Unknown Object (File)
	Wed, Nov 5, 3:16 AM

	Unknown Object (File)
	Thu, Oct 30, 12:35 PM

	Unknown Object (File)
	Wed, Oct 29, 12:13 PM

	Unknown Object (File)
	Wed, Oct 29, 11:56 AM

	Unknown Object (File)
	Wed, Oct 29, 11:40 AM

	Unknown Object (File)
	Tue, Oct 28, 5:53 AM

View All 93 Files

Subscribers

imp

Details

Reviewers

bapt
emaste

Commits

rG13916064fc39: rescue: Link with -lncursesw instead of -lncursesw_real.

Summary

ld.bfd fails to link rescue with undefined symbol errors otherwise.

This reverts commit b158d4d7a12fad8e9c4509466d5f1ebd15862d9f.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44209
Build 41097: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 1 2022, 1:08 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 1 2022, 1:08 AM

jhb requested review of this revision.Feb 1 2022, 1:08 AM

Harbormaster completed remote builds in B44209: Diff 102191.Feb 1 2022, 1:08 AM

I wonder if the change to use -lncursesw_real was a workaround for the bug where the linker scripts could be empty files during a -jX build that was subsequently fixed in c0cf36bc0210c4d74f626b944b4c7036cb01df5d.

it was yes! good catch

This revision is now accepted and ready to land.Feb 11 2022, 7:18 PM

Closed by commit rG13916064fc39: rescue: Link with -lncursesw instead of -lncursesw_real. (authored by jhb). · Explain WhyFeb 11 2022, 10:00 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG13916064fc39: rescue: Link with -lncursesw instead of -lncursesw_real..

Revision Contents
Changeset List

Path

Size

rescue/

Makefile

2 lines

Diff 102191

View Options

rescue: Link with -lncursesw instead of -lncursesw_real.ClosedPublicActions