Page MenuHomeFreeBSD
Differential D33267

dummynet: use m_rcvif_serialize/restore when queueing packets
ClosedPublic
Actions

Authored by glebius on Dec 4 2021, 9:17 PM.
Tags
None
Referenced Files
F164501909: D33267.id100628.diff
Sat, Aug 1, 12:00 PM
F164467402: D33267.diff
Sat, Aug 1, 6:02 AM
Unknown Object (File)
Sun, Jul 26, 1:09 AM
Unknown Object (File)
Wed, Jul 22, 7:23 AM
Unknown Object (File)
Wed, Jul 22, 1:36 AM
Unknown Object (File)
Tue, Jul 14, 6:47 PM
Unknown Object (File)
Fri, Jul 10, 5:21 PM
Unknown Object (File)
Fri, Jul 10, 4:03 AM
View All Files
Subscribers
ae
donner
imp
melifaro

Details

Reviewers
bz
kp
Group Reviewers
network
Commits
rG8ef7beb29edd: dummynet: use m_rcvif_serialize/restore when queueing packets
rG165746f4e4bf: dummynet: use m_rcvif_serialize/restore when queueing packets
Summary

This may not be the final patch, as I don't have enough dummynet
knowledge. Help appreciated, btw. But it allows to pass all
dummynet tests including forthcoming dummynet:ipfw_interface_removal
and dummynet:pf_interface_removal and demonstrates use of
m_rcvif_serialize() and m_rcvif_restore().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Dec 4 2021, 9:17 PM
Herald added subscribers: donner, melifaro, ae, imp. · View Herald TranscriptDec 4 2021, 9:17 PM
glebius requested review of this revision.Dec 4 2021, 9:17 PM
Harbormaster completed remote builds in B43146: Diff 99455.Dec 4 2021, 9:17 PM
glebius added a parent revision: D33266: ifnet/mbuf: provide KPI to serialize/restore m->m_pkthdr.rcvif.Dec 4 2021, 9:17 PM
glebius added a child revision: D33268: netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs.
kp mentioned this in rG5fecc5a79a38: dummynet tests: disable for now.Dec 6 2021, 5:22 PM
glebius updated this revision to Diff 100628.Dec 27 2021, 9:37 PM

Update after rebase D33265 -> D33672
Shall have zero changes.

Harbormaster completed remote builds in B43616: Diff 100628.Dec 27 2021, 9:37 PM
kp accepted this revision as: kp.Jan 25 2022, 1:39 PM
This revision is now accepted and ready to land.Jan 25 2022, 1:39 PM
Closed by commit rG165746f4e4bf: dummynet: use m_rcvif_serialize/restore when queueing packets (authored by glebius). · Explain WhyJan 27 2022, 6:01 AM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG165746f4e4bf: dummynet: use m_rcvif_serialize/restore when queueing packets.
glebius mentioned this in D33064: dummynet: purge queued packets on interface destruction.Jan 27 2022, 6:20 AM
zec added a reverting change: rG894c574ed2f2: Revert "dummynet: use m_rcvif_serialize/restore when queueing packets".May 3 2022, 5:29 PM
emaste added a commit: rG8ef7beb29edd: dummynet: use m_rcvif_serialize/restore when queueing packets.May 5 2022, 7:15 PM

Revision Contents
Changeset List

PathSize
sys/
netpfil/
ipfw/
8 lines
8 lines
10 lines
9 lines
8 lines
10 lines

Diff 101975

View Options

sys/netpfil/ipfw/dn_aqm_codel.c

Loading...
View Options

sys/netpfil/ipfw/dn_aqm_pie.c

Loading...
View Options

sys/netpfil/ipfw/dn_sched.h

Loading...
View Options

sys/netpfil/ipfw/dn_sched_fq_codel.h

Loading...
View Options

sys/netpfil/ipfw/dn_sched_fq_pie.c

Loading...
View Options

sys/netpfil/ipfw/ip_dn_io.c

Loading...