Differential D34004
website: Rework the downloads table Authored by trasz on Jan 22 2022, 6:36 PM. Tags None Referenced Files
Details
To me, the new one makes it much easier to find what I need. I've only done this for the first of the tables; I'd rather get some
Diff Detail
Event TimelineComment Actions I honestly can't judge ease of navigation and discoverability based on the AsciiDoc change. Is there an HTML preview version somewhere, or do I have to roll my own? (The latter may take me a few days to a week, but it's an option.) Comment Actions Preview: https://people.freebsd.org/~trasz/where.html And yes, I'll update the other tables too, once I'm convinced to not discard the idea instead :-) Comment Actions I think this is an improvement indeed. I think we should probably call it "Install Media Image" or something like that rather than "Disk Image", i.e. the fact that the given images are used to install is the key piece. I think there are other improvements to be made here over time but this is a good start. Comment Actions It also seems the rendered example has some other changes (e.g. the text "FreeBSD is released for a number of hardware platforms, each in number of different formats including USB memory stick images" doesn't appear in this review) Comment Actions Yeah, I'll submit the other changes for separate reviews. Regarding "Installer images" - problem is, not all of those are installer images. I wonder if I should perhaps split off SD card images like it was before... Also: is there a way to make cells vertically aligned up, as opposed to vertically centered, as it is now? The example from AsciiDoc didn't seem to work for some reason. Comment Actions I'm a bit confused about what you mean by installer image vs cd images - if I look at https://www.freebsd.org/where/#download-rel130 the SD card images are separate from the installer images. I think we're gonna have to ask @carlavilla - I spent some time trying to figure out why the AsciiDoc example (I assume that's the one you're talking about) isn't working, but don't really have a clue except that it might be in doc/website/themes/beastie/layouts? Comment Actions Right - and in the table this patch introduces they are no longer separate. I've tried with additional column, but that looks weird - it becomes both overcrowded and sparse at the same time.
Yeah. I've tried to inspect the resulting web page, but I have no idea where the vertical centering comes from; I also have no idea why the top margin within the table cell looks somewhat larger than I'd like it to be. Generally speaking, at this time, my main problem with this layout is that it's _huge_. Even a single table like this looks big, and we'd need six of those. Comment Actions If you want, send me an screenshot about what you want and I'll try to help you. Maybe we need to touch the CSS too. Comment Actions Sorry, I wasn't aware of this D34004 when I worked on D36523, D37307 and D37235.
Partly related (some overlap): – taken by @carlavilla (thanks). Comment Actions What is the status of this? Is anyone still working on it? |
Maybe just say the type of the 3rd arg depends on the operation (and document the type for each operation that takes the third arg) instead of trying to assume it's a single type? In CheriBSD we have a wrapper in libc to deal with this and have fcntl() as a truly var-args function. On existing platforms var-args is close enough to work for passing syscall arguments, but not all ABIs require this. (var-args are passed as a block in a bounded pointer on CHERI platforms and not just a continuation of register arguments).