Page MenuHomeFreeBSD
Differential D31930

boottrace: rc annotations
ClosedPublic
Actions

Authored by mhorne on Sep 13 2021, 3:19 PM.
Tags
None
Referenced Files
F148346949: D31930.id102169.diff
Tue, Mar 17, 7:07 AM
F148317401: D31930.id95045.diff
Tue, Mar 17, 3:40 AM
F148268172: D31930.id102169.diff
Mon, Mar 16, 9:50 PM
Unknown Object (File)
Tue, Feb 24, 1:28 AM
Unknown Object (File)
Feb 5 2026, 10:12 PM
Unknown Object (File)
Jan 29 2026, 10:35 PM
Unknown Object (File)
Jan 27 2026, 12:36 AM
Unknown Object (File)
Jan 16 2026, 6:58 AM
View All Files
Subscribers
0mp
allanjude
cperciva
imp
Contributor Reviews (src)
NetApp

Details

Reviewers
kevans
trasz
0mp
Group Reviewers
rc
Commits
rG318d0db5fe8a: rc.subr: boottrace annotations
Summary

Extend the rc framework to generate boottrace entries around the execution
of each rc script, if enabled.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43960
Build 40848: arc lint + arc unit

Event Timeline

mhorne created this revision.Sep 13 2021, 3:19 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptSep 13 2021, 3:19 PM
mhorne requested review of this revision.Sep 13 2021, 3:19 PM
Harbormaster completed remote builds in B41481: Diff 95045.Sep 13 2021, 3:19 PM
mhorne added parent revisions: D31929: boottrace(1): small wrapper utility, D31928: boottrace: annotate init and shutdown utilities, D30184: boottrace: a simple boot and shutdown-time tracing facility.Sep 13 2021, 3:19 PM
mhorne added reviewers: kevans, trasz, rc.Nov 8 2021, 3:30 PM
0mp added a subscriber: 0mp.Nov 9 2021, 9:07 AM
0mp added inline comments.
libexec/rc/rc.subr
1446
2221

if we use command -v here we don't have to spawn an extra process I think.

mhorne updated this revision to Diff 101577.Jan 18 2022, 3:06 PM

Handle 0mp's comments.

Harbormaster completed remote builds in B43960: Diff 101577.Jan 18 2022, 3:06 PM
0mp added inline comments.Jan 27 2022, 2:03 PM
libexec/rc/rc.subr
1414

Now that I think about it, a variable name starting with rc_ would fit better. e.g., rc_boottrace.

2222

Quoting is always a good idea here. Especially if one day we decide that boottrace_cmd is configurable.

mhorne updated this revision to Diff 102169.Jan 31 2022, 4:37 PM

Handle @0mp's comments.

Harbormaster completed remote builds in B44193: Diff 102169.Jan 31 2022, 4:37 PM
0mp accepted this revision.Feb 18 2022, 9:18 AM
0mp added inline comments.
libexec/rc/rc.subr
2223

Last minor thing would be to document that this variable is available. Ideally in rc.subr(8) where rc_* variables like rc_arg and rc_flags are documented.

Also, would be nice to add boottrace(4) to either rc or rc.subr.

This revision is now accepted and ready to land.Feb 18 2022, 9:18 AM
Closed by commit rG318d0db5fe8a: rc.subr: boottrace annotations (authored by mhorne). · Explain WhyFeb 22 2022, 12:18 AM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG318d0db5fe8a: rc.subr: boottrace annotations.
mhorne added inline comments.Feb 22 2022, 3:14 PM
libexec/rc/rc.subr
2223

Sure, I've made a note to do this as a follow-up.

Revision Contents
Changeset List

PathSize
libexec/
rc/
29 lines

Diff 101577

View Options

libexec/rc/rc.subr

Loading...