Page MenuHomeFreeBSD

boottrace: rc annotations
ClosedPublic

Authored by mhorne on Sep 13 2021, 3:19 PM.

Details

Summary

Extend the rc framework to generate boottrace entries around the execution
of each rc script, if enabled.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

0mp added inline comments.
libexec/rc/rc.subr
1445
2220

if we use command -v here we don't have to spawn an extra process I think.

libexec/rc/rc.subr
1414–1416

Now that I think about it, a variable name starting with rc_ would fit better. e.g., rc_boottrace.

2221

Quoting is always a good idea here. Especially if one day we decide that boottrace_cmd is configurable.

0mp added inline comments.
libexec/rc/rc.subr
2222

Last minor thing would be to document that this variable is available. Ideally in rc.subr(8) where rc_* variables like rc_arg and rc_flags are documented.

Also, would be nice to add boottrace(4) to either rc or rc.subr.

This revision is now accepted and ready to land.Feb 18 2022, 9:18 AM
This revision was automatically updated to reflect the committed changes.
libexec/rc/rc.subr
2222

Sure, I've made a note to do this as a follow-up.