Differential D33913

LinuxKPI: return value for linux_pci_probe()
ClosedPublic
Actions

Authored by bz on Jan 17 2022, 12:51 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 18, 7:42 AM

	Unknown Object (File)
	Thu, Aug 13, 3:08 PM

	Unknown Object (File)
	Thu, Aug 13, 3:07 PM

	Unknown Object (File)
	Thu, Aug 13, 3:05 PM

	Unknown Object (File)
	Tue, Aug 11, 8:09 PM

	Unknown Object (File)
	Sat, Aug 8, 4:20 PM

	Unknown Object (File)
	Sat, Aug 8, 2:19 PM

	Unknown Object (File)
	Thu, Aug 6, 9:15 AM

Subscribers

Details

Reviewers

imp
• hselasky

Group Reviewers

linuxkpi
x11

Commits

rG4b26b63371e7: LinuxKPI: return value for linux_pci_probe()
rG39d8c3870752: LinuxKPI: return value for linux_pci_probe()

Summary

In linux_pci_probe() return BUS_PROBE_DEFAULT rather than 0.
Using DEFAULT seems to be to best match as it will have to work for
all LinuXKPI based drivers using PCI.
Older or other native drivers can adjust their priority relative to this
more easily than to 0 (which is BUS_PROBE_SPECIFIC).

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43946
Build 40834: arc lint + arc unit

Event Timeline

bz created this revision.Jan 17 2022, 12:51 AM

Herald added a subscriber: emaste. · View Herald TranscriptJan 17 2022, 12:51 AM

bz requested review of this revision.Jan 17 2022, 12:51 AM

Harbormaster completed remote builds in B43946: Diff 101515.Jan 17 2022, 12:51 AM

Looks good.

This revision is now accepted and ready to land.Jan 17 2022, 9:08 AM

bz mentioned this in D33915: LinuxKPI: allow a driver to override the default pci probe result.Feb 11 2022, 3:48 PM

Closed by commit rG39d8c3870752: LinuxKPI: return value for linux_pci_probe() (authored by bz). · Explain WhyFeb 18 2022, 9:57 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG39d8c3870752: LinuxKPI: return value for linux_pci_probe().

bz added a commit: rG4b26b63371e7: LinuxKPI: return value for linux_pci_probe().Feb 27 2022, 11:43 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

2 lines

Diff 101515

sys/compat/linuxkpi/common/src/linux_pci.c

Loading...