Differential D33891

acpi.c: ignore _STA for atrtc SystemCMOS address space is exist if CMOS RTC Not Present bit is not set at IAPC_BOOT_ARCH in FADT.
ClosedPublic
Actions

Authored by takawata on Jan 14 2022, 5:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 7:00 AM

	Unknown Object (File)
	Fri, Dec 20, 3:28 PM

	Unknown Object (File)
	Mon, Dec 16, 10:02 AM

	Unknown Object (File)
	Thu, Dec 12, 2:05 PM

	Unknown Object (File)
	Nov 23 2024, 1:27 PM

	Unknown Object (File)
	Nov 9 2024, 8:15 PM

	Unknown Object (File)
	Nov 7 2024, 5:58 PM

	Unknown Object (File)
	Oct 18 2024, 12:35 AM

View All 50 Files

Subscribers

None

Details

Reviewers

wulf
imp
jhb

Commits

rG5c69be708433: acpi: Ignore _STA and never disable AT RTC devices

Summary

atrtc driver implements System CMOS address space and check the bit. So enable probe and attach the driver if the device is disabled.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43918
Build 40806: arc lint + arc unit

Event Timeline

takawata requested review of this revision.Jan 14 2022, 5:57 AM

takawata created this revision.

Harbormaster completed remote builds in B43918: Diff 101446.Jan 14 2022, 5:57 AM

takawata added a child revision: D33892: atrtc: Install address space handler for \_SB and its descendant..Jan 14 2022, 6:30 AM

takawata added a parent revision: D33896: atrtc.c: handle _STA object indcate it is not functional..Jan 14 2022, 6:52 AM

takawata removed a parent revision: D33896: atrtc.c: handle _STA object indcate it is not functional..Jan 14 2022, 6:54 AM

takawata added child revisions: D33896: atrtc.c: handle _STA object indcate it is not functional., D33897: Add ACPI Alarm and Day Time Driver..

Suggestion on the commit message:

acpi: Ignore _STA and never disable AT RTC devices

atrtc(4) should always install a SystemCMOS address space handler unless
the RTC Not Present bit is not set in IAPC_BOOT_ARCH in the FADT.
The atrtc(4) driver already checks this bit, but _STA can return not-present
even when this bit is clear.

This revision is now accepted and ready to land.Jan 20 2022, 7:22 PM

Closed by commit rG5c69be708433: acpi: Ignore _STA and never disable AT RTC devices (authored by takawata). · Explain WhyJan 21 2022, 6:37 AM

This revision was automatically updated to reflect the committed changes.

takawata added a commit: rG5c69be708433: acpi: Ignore _STA and never disable AT RTC devices.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

9 lines

Diff 101446

sys/dev/acpica/acpi.c

Loading...