Page MenuHomeFreeBSD
Differential D33716

Add clarifying comments
ClosedPublic
Actions

Authored by imp on Jan 1 2022, 11:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 14, 8:40 AM
Unknown Object (File)
Thu, Aug 13, 10:22 AM
Unknown Object (File)
Tue, Aug 11, 2:24 PM
Unknown Object (File)
Sun, Aug 9, 11:14 AM
Unknown Object (File)
Fri, Aug 7, 3:13 PM
Unknown Object (File)
Fri, Aug 7, 12:50 PM
Unknown Object (File)
Fri, Aug 7, 11:50 AM
Unknown Object (File)
Thu, Aug 6, 1:21 PM
View All Files
Subscribers
bdrewery
emaste

Details

Reviewers
emaste
Commits
rGe0281204cce3: Add clarifying comments
Summary

Expand on the terse comments for where each of these files is used.

Also, remove some mips specific stuff from bsd.opts.mk while I'm there.

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43669
Build 40557: arc lint + arc unit

Event Timeline

imp created this revision.Jan 1 2022, 11:51 PM
Herald added subscribers: emaste, bdrewery. · View Herald TranscriptJan 1 2022, 11:51 PM
imp requested review of this revision.Jan 1 2022, 11:51 PM
Harbormaster completed remote builds in B43669: Diff 100813.Jan 1 2022, 11:51 PM
imp added a reviewer: emaste.Jan 1 2022, 11:51 PM
emaste accepted this revision.Jan 2 2022, 12:41 AM

Thanks this does clarify the purpose of the files. I'd think the MIPS changes should be an independent commit tho.

share/mk/bsd.opts.mk
99

This should probably go in by itself?

This revision is now accepted and ready to land.Jan 2 2022, 12:41 AM
imp added inline comments.Jan 2 2022, 12:57 AM
share/mk/bsd.opts.mk
99

Agreed. I'd come to the same conclusion...

Closed by commit rGe0281204cce3: Add clarifying comments (authored by imp). · Explain WhyJan 2 2022, 7:32 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGe0281204cce3: Add clarifying comments.

Revision Contents
Changeset List

PathSize
share/
mk/
10 lines
4 lines
sys/
conf/
5 lines

Diff 100813

View Options

share/mk/bsd.opts.mk

Loading...
View Options

share/mk/src.opts.mk

Loading...
View Options

sys/conf/kern.opts.mk

Loading...