[NEW PORT] misc/unclutter-xfixes

[gor_clogic.com.ua]

Summary

Add new port misc/unclutter-xfixes, a rewrite of the popular
tool unclutter, but using the x11-xfixes extension. This means that this
rewrite doesn't use fake windows or pointer grabbing and hence causes
less problems with window managers and/or applications.

Test Plan

portlint && port test

[matthew]

misc/unclutter-xfixes/Makefile

17

Does this need to be CONFLICTS rather than CONFLICTS_INSTALL ? CONFLICTS says you can't even build this port if the conflicting software is installed.

misc/unclutter-xfixes/files/patch-Makefile

19

You shouldn't assume the setting of $LOCALBASE as /usr/local here. That can be overridden in the same way that $PREFIX can. It's fairly common to set:

CPPFLAGS=-I${LOCALBASE}/include

in the port Makefile and then pass that to the build Makefile in the MAKEFLAGS, and make this line be

CFLAGS += $(CPPFLAGS)

[gor_clogic.com.ua]

Replace CONFLICTS with CONFLICTS_INSTALL.
Use $LOCALBASE instead of hardcoded /usr/local.

[gor_clogic.com.ua]

misc/unclutter-xfixes/Makefile

17

You're right, CONFLICTS_INSTALL is better suited.

misc/unclutter-xfixes/files/patch-Makefile

19

I agree, fixed.

[gor_clogic.com.ua]

misc/unclutter-xfixes/files/patch-Makefile

19

Why not use direct CFLAGS+=-I${LOCALBASE}/include in port Makefile?

[matthew]

misc/unclutter-xfixes/files/patch-Makefile

19

Yes, you could do that. The CPPFLAGS thing is probably more to do with automake generated Makefiles

[adamw]

I have no idea why I was added to this review.

[mat]

misc/unclutter-xfixes/files/patch-Makefile

19

You don't need to patch the Makefile for that, adding it to CFLAGS will be enough, CFLAGS is added to MAKE_ENV, so it'll end up in there.

28

You should pass the version in MAKE_ENV and use it here, so that the patch doesn't have to change when updates are being made.

39–42

You don't need to patch uninstall, it will never be used.

[gor_clogic.com.ua]

Updating D6785: [NEW PORT] misc/unclutter-xfixes

Fix @mat remarks.

[gor_clogic.com.ua]

Updating D6785: [NEW PORT] misc/unclutter-xfixes

Сancel changes extraneous files.

[gor_clogic.com.ua]

Updating D6785: [NEW PORT] misc/unclutter-xfixes

Use PORTVERSION instead of constant.

[gor_clogic.com.ua]

Diff 3 broken. My mistake.

[mat]

misc/unclutter-xfixes/files/patch-Makefile

16–17

That's wrong too, not respecting ${CC}, you should add to the Makefile:

MAKE_ARGS=CC=${CC}

32

use $(BSD_INSTALL_PROGRAM) instead of $(INSTALL) -s -m 0755

33

use $(BSD_INSTALL_MAN) instead of $(INSTALL) -c -m 0644

[gor_clogic.com.ua]

Updating D6785: [NEW PORT] misc/unclutter-xfixes

Next 3 fixes from @mat.

[gor_clogic.com.ua]

Updating D6785: [NEW PORT] misc/unclutter-xfixes

Remove now unneeded INSTALL variable.

[mat]

I'm wondering if patching the Makefile is really interesting, and it feels it would be faster to have a do-build and a do-install target in the port's Makefile

misc/unclutter-xfixes/files/patch-Makefile

16–17

You don't need to remove the line.

[gor_clogic.com.ua]

Updating D6785: [NEW PORT] misc/unclutter-xfixes

Restore INSTALL variable.

[gor_clogic.com.ua]

I agree with you. With five source files and two target files write custom do-build and a do-install steps will be faster. But now, port working and may be committed or I need to rewrite Makefile to use do-build and a do-install steps?

[pi]

Needs BUILD_DEPENDS=a2x:textproc/asciidoc for the manpage, testbuilds are OK, portlint is fine as well.

[pi]

That BUILD_DEPENDS stuff. Sorry it went into a comment.

[pi]

misc/unclutter-xfixes/Makefile

14

It needs

BUILD_DEPENDS= a2x:textproc/asciidoc

[gor_clogic.com.ua]

Updating D6785: [NEW PORT] misc/unclutter-xfixes

Add BUILD_DEPENDS for the manpage as requested @pi.

[gor_clogic.com.ua]

Can anyone commit this?

[mat]

misc/unclutter-xfixes/files/patch-Makefile

15

Removing that line is not needed.

[gor_clogic.com.ua]

misc/unclutter-xfixes/files/patch-Makefile

15

That line replace $CC from MAKE_ARGS with hardcoded gcc. gcc is not in BUILD_DEPENDS for this port and should not be there.

[mat]

misc/unclutter-xfixes/files/patch-Makefile

15

When you pass a variable as an argument to the make command, it overrides the variable defined in the Makefile.

[gor_clogic.com.ua]

Updating D6785: [NEW PORT] misc/unclutter-xfixes

Restore line form original Makefile.

[gor_clogic.com.ua]

misc/unclutter-xfixes/files/patch-Makefile

15

You are right, reverted.

[gor_clogic.com.ua]

Filed Issue for this https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210302