sysconf(8) --version now prints the library version alongside its
own so each can move on its own clock. Assigning a bitmask to
bool already converts zero/nonzero; drop the redundant != 0 (fuz).
Details
Details
- Reviewers
fuz kfv adrian - Commits
- rG0380d016d9ba: libbsdconf: independent version macros
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
It sounds dangerous to have library and tool at different versions. Do you plan to keep a stable API? Do you test mismatching command and library versions with one another and/or expect them to work? If not, consider instead to enforce that both be updated in lock step.
| lib/libbsdconf/bsdconf.c | ||
|---|---|---|
| 428 | At this point you can drop the parentheses, too. | |
Comment Actions
Discussed offline together. They are not expected to be aligned and Semantic Versioning (SemVer) is being used to enable API tracking.
Do you plan to keep a stable API?
Yes.
Do you test mismatching command and library versions with one another and/or expect them to work?
They are not expected to stay in sync. They are expected to drift. Them being in sync here is pure coincidence.
If not, consider instead to enforce that both be updated in lock step.
When a change touches only the library, only the library version gets bumped. Likewise when only the utility code gets touched, only that version gets bumped. Only when both are touched at the same time do both get an appropriate version bump (and not necessarily the same type of bump -- for example, bumping library PATCH while bumping utilities MINOR)