raw ip: clear sin_port on bind(2)
AcceptedPublic
Actions

Authored by glebius on Thu, Sep 10, 2:03 PM.

Details

Reviewers

bnovkov
pouria
adrian

Group Reviewers

network

Summary

Application may set sin_port to some value. Although this value is not
used by SOCK_RAW, it breaks a check that the address is available. A
perfect fix would be not use sockaddrs for ifaddrs, but that would be a
bigger change.

PR: 298366
Fixes: 948ad32ae1e0811f45e1d38f26636fefed5051f0

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76747
Build 73630: arc lint + arc unit

Event Timeline

glebius created this revision.Thu, Sep 10, 2:03 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptThu, Sep 10, 2:03 PM

glebius requested review of this revision.Thu, Sep 10, 2:03 PM

Harbormaster completed remote builds in B76747: Diff 186384.Thu, Sep 10, 2:03 PM

adrian accepted this revision.Thu, Sep 10, 2:27 PM

This revision is now accepted and ready to land.Thu, Sep 10, 2:27 PM

bnovkov accepted this revision.Thu, Sep 10, 2:50 PM

What if the application set the sin6_flowinfo too?

In D59570#1366888, @pouria wrote:

What if the application set the sin6_flowinfo too?

Good question. Probably same bug? We just didn't encounter application that sets it.

This change is good by nature. but it would be nice to have a comment above sa_equal in case we forget the original issue

Revision Contents
Changeset List

Path

Size

sys/

netinet/

raw_ip.c

2 lines

Diff 186384

View Options

raw ip: clear sin_port on bind(2)AcceptedPublicActions