Page MenuHomeFreeBSD
Differential D59570

raw ip: clear sin_port on bind(2)
ClosedPublic
Actions

Authored by glebius on Sep 10 2026, 2:03 PM.
Tags
None
Referenced Files
F175360361: D59570.id186510.diff
Sat, Oct 10, 7:01 AM
Unknown Object (File)
Fri, Oct 9, 5:15 AM
Unknown Object (File)
Tue, Oct 6, 7:46 AM
Unknown Object (File)
Mon, Oct 5, 3:56 AM
Unknown Object (File)
Sun, Oct 4, 1:36 PM
Unknown Object (File)
Sat, Oct 3, 8:58 PM
Unknown Object (File)
Sat, Oct 3, 8:58 PM
Unknown Object (File)
Sat, Oct 3, 12:29 AM
View All 60 Files
Subscribers
imp
melifaro

Details

Reviewers
bnovkov
pouria
adrian
Group Reviewers
network
Commits
rGbcc27cf809d2: raw ip: clear sin_port on bind(2)
rG465942e8cc81: raw ip: clear sin_port on bind(2)
Summary

Application may set sin_port to some value. Although this value is not
used by SOCK_RAW, it breaks a check that the address is available. A
perfect fix would be not use sockaddrs for ifaddrs, but that would be a
bigger change.

PR: 298366
Fixes: 948ad32ae1e0811f45e1d38f26636fefed5051f0

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Sep 10 2026, 2:03 PM
Herald added subscribers: melifaro, imp. · View Herald TranscriptSep 10 2026, 2:03 PM
glebius requested review of this revision.Sep 10 2026, 2:03 PM
Harbormaster completed remote builds in B76747: Diff 186384.Sep 10 2026, 2:03 PM
adrian accepted this revision.Sep 10 2026, 2:27 PM
This revision is now accepted and ready to land.Sep 10 2026, 2:27 PM
bnovkov accepted this revision.Sep 10 2026, 2:50 PM
pouria added a comment.Sep 10 2026, 3:53 PM

What if the application set the sin6_flowinfo too?

glebius added a comment.Thu, Sep 10, 11:20 PM
In D59570#1366888, @pouria wrote:

What if the application set the sin6_flowinfo too?

Good question. Probably same bug? We just didn't encounter application that sets it.

pouria accepted this revision.Fri, Sep 11, 7:08 AM

This change is good by nature. but it would be nice to have a comment above sa_equal in case we forget the original issue

Closed by commit rG465942e8cc81: raw ip: clear sin_port on bind(2) (authored by glebius). · Explain WhySat, Sep 12, 12:14 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG465942e8cc81: raw ip: clear sin_port on bind(2).
glebius added a commit: rGbcc27cf809d2: raw ip: clear sin_port on bind(2).Thu, Sep 24, 3:33 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines

Diff 186510

View Options

sys/netinet/raw_ip.c

Loading...