SYSINIT: add SI_SUB_FIRST
ClosedPublic
Actions

Authored by glebius on Fri, Aug 7, 10:18 PM.

Details

Reviewers

Group Reviewers

Src Committers
srcmgr

Commits

rG4f2465260f03: SYSINIT: add SI_SUB_FIRST

Summary

This allows to initialize mp_maxid, mp_ncpus and register APICs at the
most early stage, guaranteeing that those values will already be available
at SI_SUB_TUNABLES.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Fri, Aug 7, 10:18 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Aug 7, 10:18 PM

glebius requested review of this revision.Fri, Aug 7, 10:18 PM

Harbormaster completed remote builds in B75445: Diff 183643.Fri, Aug 7, 10:18 PM

glebius added a parent revision: D58711: linker: rely on kick_init running at SI_ORDER_MIDDLE.Fri, Aug 7, 10:18 PM

glebius added a child revision: D58713: SYSINIT: add SI_SUB_NUMA.

markj added a subscriber: markj.Mon, Aug 10, 1:20 PM

markj added inline comments.

sys/sys/kernel.h
97	Can we just call it _EARLY or _FIRST? APIC is specific to x86. Or call it SI_SUB_NUMCPUS or something, to make it clear it's used for counting CPUs. arm64's mp_setmaxid() could use it too. Or, just use SI_SUB_TUNABLES/SI_ORDER_FIRST. That's what arm64 and !SMP kernels do.

glebius added inline comments.Mon, Aug 10, 8:35 PM

sys/sys/kernel.h
97	I will use SI_SUB_FIRST as there already exists SI_SUB_LAST. I don't like to resort to SI_SUB_TUNABLES/SI_ORDER_FIRST, as that would require all real tunables [that care about number of CPUs] to start with SI_ORDER_SECOND. The SI_SUB_FIRST would allow to provide any other info that maybe needed before tunables if any appears in the future.