Page MenuHomeFreeBSD
Differential D58327

procdesc: report NOTE_PDSIGCHLD for traced/stopped process
ClosedPublic
Actions

Authored by kib on Sat, Jul 18, 5:35 PM.
Tags
None
Referenced Files
F163447654: D58327.diff
Thu, Jul 23, 7:07 AM
Unknown Object (File)
Wed, Jul 22, 4:07 AM
Unknown Object (File)
Wed, Jul 22, 3:47 AM
Unknown Object (File)
Wed, Jul 22, 3:14 AM
Unknown Object (File)
Tue, Jul 21, 7:43 PM
Unknown Object (File)
Tue, Jul 21, 4:10 AM
Unknown Object (File)
Sun, Jul 19, 6:08 PM
Subscribers
imp
olce

Details

Reviewers
kevans
markj
Commits
rGb328975b9d7c: procdesc: report NOTE_PDSIGCHLD for traced and stopped process
Summary
on attach of the knote.  It is same as for NOTE_EXIT when attaching to
the exiting process.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Sat, Jul 18, 5:35 PM
Herald added subscribers: olce, imp. · View Herald TranscriptSat, Jul 18, 5:35 PM
kib requested review of this revision.Sat, Jul 18, 5:35 PM
markj added inline comments.Sun, Jul 19, 6:13 PM
sys/kern/sys_procdesc.c
504

The code is just checking whether the proc is stopped, it might not be traced.

510
kib marked 2 inline comments as done.Sun, Jul 19, 6:42 PM
kib added inline comments.
sys/kern/sys_procdesc.c
504

P_STOPPED_TRACE means that the process is traced (and stopped in ptracestop()).
Checking P_STOPPED_TRACE might be redundant, but I think it is more correct to check.

markj added inline comments.Sun, Jul 19, 6:45 PM
sys/kern/sys_procdesc.c
504

I mean, we will generate an event if just P_STOPPED_SIG is set. In that case, the process might not be traced.

kib updated this revision to Diff 182242.Sun, Jul 19, 6:45 PM
kib marked an inline comment as done.

Use atomic to load p_flag.

kib marked an inline comment as done.Sun, Jul 19, 6:52 PM
kib added inline comments.
sys/kern/sys_procdesc.c
504

I added 'stopped or traced'.

kib updated this revision to Diff 182249.Sun, Jul 19, 6:52 PM
kib marked an inline comment as done.

Update comment.

markj accepted this revision.Mon, Jul 20, 12:45 AM
markj added inline comments.
sys/kern/sys_procdesc.c
504
This revision is now accepted and ready to land.Mon, Jul 20, 12:45 AM
kib marked an inline comment as done.Mon, Jul 20, 1:59 AM
Closed by commit rGb328975b9d7c: procdesc: report NOTE_PDSIGCHLD for traced and stopped process (authored by kib). · Explain WhyMon, Jul 20, 2:01 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGb328975b9d7c: procdesc: report NOTE_PDSIGCHLD for traced and stopped process.

Revision Contents
Changeset List

PathSize
sys/
kern/
15 lines

Diff 182269

View Options

sys/kern/sys_procdesc.c

Loading...