Page MenuHomeFreeBSD
Differential D58172

pdwait(2): make debugging events functional
ClosedPublic
Actions

Authored by kib on Sat, Jul 11, 3:52 PM.
Tags
None
Referenced Files
F162588727: D58172.id181776.diff
Tue, Jul 14, 8:15 PM
Unknown Object (File)
Tue, Jul 14, 1:47 AM
Subscribers
imp
olce

Details

Reviewers
markj
kevans
Commits
rG0f1718e0d588: pdwait(2): make debugging events functional
Summary

We need to wake up the pdwait(2) waiters when procdesc event is reported.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Sat, Jul 11, 3:52 PM
Herald added subscribers: olce, imp. · View Herald TranscriptSat, Jul 11, 3:52 PM
kib requested review of this revision.Sat, Jul 11, 3:52 PM
markj added a comment.Sun, Jul 12, 5:18 PM

Shouldn't this just be in D58123?

kib added a comment.Sun, Jul 12, 5:47 PM
In D58172#1334637, @markj wrote:

Shouldn't this just be in D58123?

IMO it is independent, it was missing wakeups which must be present for pdwait() to return. IMO even if NOTE_PDSIGCHLD is not going in, this change is still required. Which is why I put it into a separate commit and review.

markj accepted this revision.Mon, Jul 13, 12:35 AM
This revision is now accepted and ready to land.Mon, Jul 13, 12:35 AM
Closed by commit rG0f1718e0d588: pdwait(2): make debugging events functional (authored by kib). · Explain WhyMon, Jul 13, 3:13 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG0f1718e0d588: pdwait(2): make debugging events functional.

Revision Contents
Changeset List

PathSize
sys/
kern/
1 line

Diff 181873

View Options

sys/kern/sys_procdesc.c

Loading...