smp: remove unused hlt_cpus_mask
ClosedPublic
Actions

Authored by mhorne on Fri, Jul 10, 5:31 PM.

Details

Reviewers

kib
olce

Commits

rGdf0aca0d7306: smp: remove unused hlt_cpus_mask

Summary

It is a relic, apparently once populated by a machdep.hlt_cpus sysctl.
The sysctl was removed, and ULE has never honored this mask. It is now
safe to remove.

Remove the mask, and its few remaning references in: sched_4bsd(4),
hwpmc(4), and hwt(4).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Fri, Jul 10, 5:31 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jul 10, 5:31 PM

mhorne requested review of this revision.Fri, Jul 10, 5:31 PM

Harbormaster completed remote builds in B74707: Diff 181737.Fri, Jul 10, 5:31 PM

mhorne added a parent revision: D58157: g_eli: better handling of absent/disabled CPUs.Fri, Jul 10, 5:31 PM

mhorne added a child revision: D58159: sched/lapic: remove sched_do_timer_accounting().

kib accepted this revision.Fri, Jul 10, 6:42 PM

kib added inline comments.

sys/kern/kern_pmc.c
154–155	Can all these `#ifdef SMP` be removed? Why wouldn't the SMP case work for !SMP?
sys/kern/sched_4bsd.c
1828	do_timer_accounting now does not have any function, it should be removed. Ahh, you do it in the next review.

This revision is now accepted and ready to land.Fri, Jul 10, 6:42 PM

olce accepted this revision.Fri, Jul 10, 7:09 PM

olce added inline comments.

sys/kern/kern_pmc.c
154–155	All SMP cases work exactly the same on !SMP (except `pmc_cpu_is_primary()`, which now depends on the hardware not messing up).

mhorne added inline comments.Sun, Jul 12, 7:43 PM

sys/kern/kern_pmc.c
154–155	Most of these functions can in fact be removed completely, or inlined. I have a WIP branch to clean this up, it only requires a small sweep of the hwpmc code.